Noah/fix window reference #77
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarahhpeng
approved these changes
May 27, 2024
andreisito
pushed a commit
that referenced
this pull request
Jul 24, 2024
* fix: move window into useEffect * fix: remove news state dependency from useEffect
andreisito
added a commit
that referenced
this pull request
Sep 16, 2024
* feat: web screens met, testing on iPhone SE screens + switch to web: instead of md: needed * feat: iPhone SE debugged, window containers required * chore: sync * feat+bug: Hover and Focus effects added to visitor resources buttons. Custom shadow classes added to tailwind config, for use in future hifi styles. Hunter-cream renamed to hunter-cream for figma design system consistency. syncing but some weird issues with the npm run pre-commit command, some files committed by mistake * chore: Added hover + focus effects to buttons, reorganized files relating to the home page components * fix: padding on title header and sizing of exhibit button styling, Galaxy Fold 5 boundary issues + button icon gap fixes incoming * fix: Galaxy Fold 5 + Iphone SE boundary error fixed. Note: aim to use max prefix on measurements for parent tags to avoid this in the future * fix: fixed bounding issues again + visitor resources button styling fixes * feat: transition to using React Context for window resize checks, should look into using other React Contexts in the future * Claire fixes (#63) * done with popup styling * updated package lock for npm install * Revert "fix: remove formatting changes to media/queries.tsx" This reverts commit f6e1d69. * cont. rebase * cont. rebase * rebase 3 * rebase 4 * refactor: add formatting changes * refactor: add jsdoc, imports, change queries.tsx -> .ts * edited to accomodate database changes for categories and exhibits * claire's approval * figma dev changes resolved * updated desktop version * finished all desktop feedback - delted display component (not using) changed navbar component to huntergreen * done with claire's mobile edits --------- Co-authored-by: sarahhpeng <[email protected]> Co-authored-by: Noah Hernandez <[email protected]> Co-authored-by: jxmoose <[email protected]> * Revert "Claire fixes (#63)" (#64) This reverts commit 8faac52. * package changed * change useWebScreenDetection to useWebDeviceDetection (#68) * fixed some linting errors, mostly jsdocs (#69) * news feed web (#61) * news feed web * small change * added web screen, fixed styling when screen between certain sizes, fixed coloring using h-full (?), changed margins to padding, changed to rem * just used gradient for now for epic styling lol.. * changed bg to mint cream for now :( * changed web detection * removed text from web --------- Co-authored-by: sarahhpeng <[email protected]> * Justin exhibit redo (#67) * added database and page * fixed lint errors lol... * style changes * prettier * added database and page * fixed lint errors lol... * update package-lock * small style * added exhibit component * adding comp * finished? * added to nav bar * removed cateogry for now * prettier changes * feat: disabling github actions until MPH / post-MPH * chore: prettier * chore: disabled only the tsc compiler for now * adding comp * finished? * prettier changes * removed category from table and small fixes * added linking from map * added database and page * fixed lint errors lol... * style changes * prettier * added database and page * fixed lint errors lol... * update package-lock * small style * added exhibit component * adding comp * finished? * added to nav bar * removed cateogry for now * prettier changes * feat: disabling github actions until MPH / post-MPH * chore: prettier * chore: disabled only the tsc compiler for now * adding comp * finished? * prettier changes * removed category from table and small fixes * added linking from map * design changes + adding active state to buttons * big database edits to make fun facts possible on map * supabase function change * documentation changes + tailwind changes * small styling changes * some wbe changes * maybe will make components equal heightsl ater if have time i cant figure it out lol fml * web resize changes * edit nav bar * added database and page * fixed lint errors lol... * style changes * prettier * added database and page * fixed lint errors lol... * update package-lock * small style * added exhibit component * adding comp * finished? * added to nav bar * removed cateogry for now * prettier changes * feat: disabling github actions until MPH / post-MPH * chore: prettier * chore: disabled only the tsc compiler for now * adding comp * finished? * prettier changes * removed category from table and small fixes * added linking from map * added database and page * fixed lint errors lol... * style changes * prettier * fixed lint errors lol... * update package-lock * small style * added exhibit component * adding comp * finished? * added to nav bar * removed cateogry for now * prettier changes * adding comp * finished? * prettier changes * removed category from table and small fixes * added linking from map * design changes + adding active state to buttons * big database edits to make fun facts possible on map * supabase function change * documentation changes + tailwind changes * small styling changes * some wbe changes * maybe will make components equal heightsl ater if have time i cant figure it out lol fml * web resize changes * edit nav bar * small post rebase fixes --------- Co-authored-by: Andrei Tan <[email protected]> Co-authored-by: sarahhpeng <[email protected]> * fixed all eslint errors, still some warnings, introduced some ignores (#70) Co-authored-by: sarahhpeng <[email protected]> * fixed remaining errors (#71) * Phs sitemap fix (#66) * done with popup styling * updated package lock for npm install * Revert "fix: remove formatting changes to media/queries.tsx" This reverts commit f6e1d69. * cont. rebase * cont. rebase * rebase 3 * rebase 4 * refactor: add formatting changes * refactor: add jsdoc, imports, change queries.tsx -> .ts * edited to accomodate database changes for categories and exhibits * claire's approval * figma dev changes resolved * updated desktop version * finished all desktop feedback - delted display component (not using) changed navbar component to huntergreen * done with claire's mobile edits * added working nav bar to mihas pr * fixed bracket issue in the siteMapPage * filter button duplicated import statement * changed hunterGreen to hunter-green for filter button * testing w-auto * minor change * fixed alignment issues and used andrei's resizing * fixed popup alignment * resolved justin's comments * fixed fonts * fixing lag from tours to exhibit * combined use affects * trying to push with eslint fixes * fixed eslint errors - ready to push --------- Co-authored-by: sarahhpeng <[email protected]> Co-authored-by: Noah Hernandez <[email protected]> Co-authored-by: jxmoose <[email protected]> * Christophertorres/phs final tours spotlights styling (#62) * . * refinements * . * style: make navbar sticky * style: rename pages * feat: hours and location web layout * style: make image carousel fit to parent container * style: update mobile and web designs * style: fix virtual tours button radius * style: tour end page fills screen height * style: back to tours button height adjustment * style: adjust button-text spacing * style: update space between title and subtitle for spotlight buttons * style * style: fix button radius under more in this spotlight * style: add back button click effect * style: tour button with text click effect * style: add last and next stop button click effects * style: add spotlight display button click effect * style: text on click effect * style: add line clamp 2 to related spotlights * style: specifically define each font feature * feat: add links table to supabase * style: related links component uses new links table * style: fix eslint and prettier errors * style: rename navBar.tsx to NavBar.tsx * style: update page path names * feat: add exhibits to navigation bar * style: fix eslint and prettier issues * style: fix text overflow in spotlight page * deleted outdated images from public folder and updated navBar folder to NavBar (#72) * renamed navBar to NavBar (#73) * Phs site map eslint (#74) * fixed colors and deleted the ts file for category queries * supabase fix * supabase types added * fixed eslint and prettier things for all pages pertaining to site maps * Justin footer redo (#75) * added footer file * added footer component to all pages, plus small edits to footer * made links open new tab instead of change exisitng --------- Co-authored-by: sarahhpeng <[email protected]> * Noah/fix window reference (#77) * fix: move window into useEffect * fix: remove news state dependency from useEffect * added correct links to site map (#76) * added correct links to site map * made images fit to exhibit component * merge resolved * style * nothing * feat: iPhone SE debugged, window containers required * feat+bug: Hover and Focus effects added to visitor resources buttons. Custom shadow classes added to tailwind config, for use in future hifi styles. Hunter-cream renamed to hunter-cream for figma design system consistency. syncing but some weird issues with the npm run pre-commit command, some files committed by mistake * chore: Added hover + focus effects to buttons, reorganized files relating to the home page components * fix: misc changes to styling and fixing some console log errors * feat + fix: web design system set up, fixed lato font * fix: resolving old merge conflicts * feat: web screens met, testing on iPhone SE screens + switch to web: instead of md: needed * feat: iPhone SE debugged, window containers required * chore: sync * feat+bug: Hover and Focus effects added to visitor resources buttons. Custom shadow classes added to tailwind config, for use in future hifi styles. Hunter-cream renamed to hunter-cream for figma design system consistency. syncing but some weird issues with the npm run pre-commit command, some files committed by mistake * chore: Added hover + focus effects to buttons, reorganized files relating to the home page components * Claire fixes (#63) * done with popup styling * updated package lock for npm install * Revert "fix: remove formatting changes to media/queries.tsx" This reverts commit f6e1d69. * cont. rebase * cont. rebase * rebase 3 * rebase 4 * refactor: add formatting changes * refactor: add jsdoc, imports, change queries.tsx -> .ts * edited to accomodate database changes for categories and exhibits * claire's approval * figma dev changes resolved * updated desktop version * finished all desktop feedback - delted display component (not using) changed navbar component to huntergreen * done with claire's mobile edits --------- Co-authored-by: sarahhpeng <[email protected]> Co-authored-by: Noah Hernandez <[email protected]> Co-authored-by: jxmoose <[email protected]> * Revert "Claire fixes (#63)" (#64) This reverts commit 8faac52. * merge resolved * style * nothing * feat: iPhone SE debugged, window containers required * feat+bug: Hover and Focus effects added to visitor resources buttons. Custom shadow classes added to tailwind config, for use in future hifi styles. Hunter-cream renamed to hunter-cream for figma design system consistency. syncing but some weird issues with the npm run pre-commit command, some files committed by mistake * chore: Added hover + focus effects to buttons, reorganized files relating to the home page components * fix: misc changes to styling and fixing some console log errors * feat + fix: web design system set up, fixed lato font * fix: resolving old merge conflicts * sync with origin --------- Co-authored-by: miha-bhaskaran <[email protected]> Co-authored-by: sarahhpeng <[email protected]> Co-authored-by: Noah Hernandez <[email protected]> Co-authored-by: jxmoose <[email protected]> Co-authored-by: sarahhpeng <[email protected]> Co-authored-by: David Qing <[email protected]> Co-authored-by: Justin Xue <[email protected]> Co-authored-by: Chris Torres <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✨ New in this PR ✨
One liner: what did you do? 🛠
Moves window references in use effects, removes testing page, minimize fetchAllNewsByDate query calls.
🏚 cc: @sarahhpeng @andreisito