Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: global booking limits for teams #16614

Merged
merged 48 commits into from
Sep 23, 2024
Merged

Conversation

CarinaWolli
Copy link
Member

@CarinaWolli CarinaWolli commented Sep 12, 2024

What does this PR do?

Adds a new feature for global booking limits for teams. Team global booking limits determine how many time team members can be booked from team event types (collective, round-robin)

Screenshot 2024-09-17 at 6 14 02 PM

Also fixes an existing bug with booking limits when host and attendees were in different timezones. Slots didn't load correctly and when trying to confirm the booking it was throwing Could not book the meeting. Booking Limit for this event type has been reached

Also fixes issues with booking limits (duration and frequency) when event is rescheduled. It sometimes caused slots not to show up or for duration limits slots were correctly shown but it was throwing Could not reschedule the meeting. Duration Limit for this event type has been reached after confirming the bookings

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have added a Docs issue: Global booking limits for teams docs#139
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Go to settings/team/[id]/bookingLimits
  • Add some limits
  • book team event types (collective, round-robin, managed) and see if it works as expected

Copy link

vercel bot commented Sep 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 5:45pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Sep 23, 2024 5:45pm

@github-actions github-actions bot added the ❗️ migrations contains migration files label Sep 12, 2024
@keithwillcode keithwillcode added consumer core area: core, team members only labels Sep 12, 2024
zomars
zomars previously approved these changes Sep 19, 2024
Copy link
Member

@zomars zomars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM from here

Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I found that I can save 3 per day and 1 per year but on the event types limits it'll throw an error if I try that. Let's catch that edge case and then we can approve.

@CarinaWolli
Copy link
Member Author

ave 3 per day and 1 per year but on the event types limits it'll throw an error if I try that. Let's catch that edge case and then we can approve.

fixed 👍

Copy link
Contributor

@joeauyeung joeauyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feedback addressed. Great work @CarinaWolli!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking 🐛 bug Something isn't working consumer core area: core, team members only ✨ feature New feature or request High priority Created by Linear-GitHub Sync 🧹 Improvements Improvements to existing features. Mostly UX/UI linear Sync Github Issue from community members to Linear.app Medium priority Created by Linear-GitHub Sync ❗️ migrations contains migration files ready-for-e2e Stale teams area: teams, round robin, collective, managed event-types
Projects
None yet
4 participants