perf: don't fetch all the hosts [DO NOT MERGE] #18319
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keithwillcode
added
core
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 2 Skipped Deployments
|
Udit-takkar
changed the title
dosubot
bot
added
the
performance
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/21/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add foundation team as reviewer" took an action on this PR • (12/23/24)1 reviewer was added to this PR based on Keith Williams's automation. |
E2E results are ready! |
Udit-takkar
commented
Dec 23, 2024
| @@ -178,7 +178,7 @@ const EmailEmbed = ({ | |||
| ], | |||
| shallow | |||
| ); | |||
| const event = useEvent(); | |||
| const event = useEvent({ limitHostsToThree: true }); | |||
There was a problem hiding this comment.
we don't need all the hosts on the front end
Udit-takkar
commented
Dec 23, 2024
| select: userSelect, | ||
| }, | ||
| }, | ||
| ...(limitHostsToThree ? { take: 3 } : {}), |
There was a problem hiding this comment.
We would still need all the hosts for single event type page so we don't want the limit everytime
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Testing if we need all the hosts. Do not merge this PR
Same event type with 1300+ hosts
BEFORE:-
AFTER:-
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?