Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix for 'Scheduling by cal.com' is still showing in workflow emails even when branding is disabled #18862

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

sn10-debug
Copy link

@sn10-debug sn10-debug commented Jan 24, 2025

What does this PR do?

This Checks for user has disabled branding, team has disabled branding or Organization has disabled branding based on the workflows.

For the User workflows, it checks for the hideBranding key in the User Schema
For the Team workflows, it checks for the hideBranding key in the Team Schema
For checking for the Organization workflows, it check first checks whether the sub-team which created the workflow has a parent Team or not and if it is then it identifies as a Organization and automatically disables branding

image

This helps check for the disability of branding on all the workflows

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

To test this, Reminders can be created on the different category of workflows and then checked for the branding in the received reminders. For SMS, it is not required to check as it is in Pro Plan. This should only be tested in CustomTemplate and ReminderEmailTemplate.

Copy link

vercel bot commented Jan 24, 2025

@sn10-debug is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@CLAassistant
Copy link

CLAassistant commented Jan 24, 2025

CLA assistant check
All committers have signed the CLA.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Jan 24, 2025
@graphite-app graphite-app bot requested review from a team January 24, 2025 11:24
Copy link
Contributor

github-actions bot commented Jan 24, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "'Scheduling by cal.com' is still showing in workflow emails even when branding is disabled". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@dosubot dosubot bot added this to the v4.10 milestone Jan 24, 2025
@github-actions github-actions bot added ❗️ .env changes contains changes to env variables emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email High priority Created by Linear-GitHub Sync workflows area: workflows, automations 🐛 bug Something isn't working labels Jan 24, 2025
Copy link

graphite-app bot commented Jan 24, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (01/24/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (01/24/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (01/24/25)

1 label was added to this PR based on Keith Williams's automation.

@sn10-debug sn10-debug changed the title 'Scheduling by cal.com' is still showing in workflow emails even when branding is disabled fix: Fix for 'Scheduling by cal.com' is still showing in workflow emails even when branding is disabled Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working community Created by Linear-GitHub Sync emails area: emails, cancellation email, reschedule email, inbox, spam folder, not getting email ❗️ .env changes contains changes to env variables High priority Created by Linear-GitHub Sync workflows area: workflows, automations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-5041] Branding in workflow emails
2 participants