Skip to content

Commit

Permalink
Remove MaskedAbsOr(Zero) covered with arithmetic tests
Browse files Browse the repository at this point in the history
  • Loading branch information
mazimkhan committed Nov 22, 2024
1 parent d68360c commit 49433a8
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 21 deletions.
3 changes: 0 additions & 3 deletions g3doc/quick_reference.md
Original file line number Diff line number Diff line change
Expand Up @@ -886,9 +886,6 @@ not a concern, these are equivalent to, and potentially more efficient than,
<code>V **MaskedSatSubOr**(V no, M m, V a, V b)</code>: returns `a[i] +
b[i]` saturated to the minimum/maximum representable value, or `no[i]` if
`m[i]` is false.
* `V`: `{i,f}` \
<code>V **MaskedAbsOr**(M m, V a, V b)</code>: returns the absolute value of
`a[i]` where m is active and returns `b[i]` otherwise.

#### Shifts

Expand Down
6 changes: 0 additions & 6 deletions hwy/ops/arm_sve-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -892,12 +892,6 @@ HWY_SVE_FOREACH_IF(HWY_SVE_RETV_ARGPV, Abs, abs)
HWY_SVE_FOREACH_I(HWY_SVE_RETV_ARGPV, SaturatedAbs, qabs)
#endif // HWY_SVE_HAVE_2

// ------------------------------ MaskedAbsOr
HWY_SVE_FOREACH_IF(HWY_SVE_RETV_ARGMV_M, MaskedAbsOr, abs)

// ------------------------------ MaskedAbsOrZero
HWY_SVE_FOREACH_IF(HWY_SVE_RETV_ARGMV_Z, MaskedAbsOrZero, abs)

// ================================================== ARITHMETIC

// Per-target flags to prevent generic_ops-inl.h defining Add etc.
Expand Down
12 changes: 0 additions & 12 deletions hwy/ops/generic_ops-inl.h
Original file line number Diff line number Diff line change
Expand Up @@ -672,18 +672,6 @@ HWY_API V SaturatedAbs(V v) {

#endif

// ------------------------------ MaskedAbsOr
template <class V, HWY_IF_SIGNED_V(V), class M>
HWY_API V MaskedAbsOr(M m, V v, V no) {
return IfThenElse(m, Abs(v), no);
}

// ------------------------------ MaskedAbsOrZero
template <class V, HWY_IF_SIGNED_V(V), class M>
HWY_API V MaskedAbsOrZero(M m, V v) {
return IfThenElseZero(m, Abs(v));
}

// ------------------------------ Reductions

// Targets follow one of two strategies. If HWY_NATIVE_REDUCE_SCALAR is toggled,
Expand Down

0 comments on commit 49433a8

Please sign in to comment.