Merge pull request #4 from intellifylearning/optimize

chunk up into 20 max
camitz · Sep 17, 2016 · 0613935 · 0613935
2 parents 6b28252 + 42637ee
commit 0613935
Showing 1 changed file with 39 additions and 60 deletions.
diff --git a/lib/aws-cloudwatch-statsd-backend.js b/lib/aws-cloudwatch-statsd-backend.js
@@ -47,6 +47,41 @@ CloudwatchBackend.prototype.processKey = function(key) {
   };
 };
 
+CloudwatchBackend.prototype.chunk = function(arr, chunkSize) {
+
+  var groups = [],
+    i;
+  for (i = 0; i < arr.length; i += chunkSize) {
+    groups.push(arr.slice(i, i + chunkSize));
+  }
+  return groups;
+};
+
+CloudwatchBackend.prototype.batchSend = function(currentMetricsBatch, namespace) {
+
+  // send off the array (instead of one at a time)
+  if (currentMetricsBatch.length > 0) {
+
+    // Chunk into groups of 20
+    var chunkedGroups = this.chunk(currentMetricsBatch, 20);
+
+    for (var i = 0, len = chunkedGroups.length; i < len; i++) {
+      this.cloudwatch.putMetricData({
+        MetricData: chunkedGroups[i],
+        Namespace: namespace
+      }, function(err, data) {
+        if (err) {
+          // log an error
+          console.log(util.inspect(err));
+        } else {
+          // Success
+          // console.log(util.inspect(data));
+        }
+      });
+    }
+  }
+};
+
 CloudwatchBackend.prototype.flush = function(timestamp, metrics) {
 
   console.log('Flushing metrics at ' + new Date(timestamp * 1000).toISOString());
@@ -80,21 +115,7 @@ CloudwatchBackend.prototype.flush = function(timestamp, metrics) {
     });
   }
 
-  // send off the array (instead of one at a time)
-  if (currentCounterMetrics.length > 0) {
-    this.cloudwatch.putMetricData({
-      MetricData: currentCounterMetrics,
-      Namespace: namespace
-    }, function(err, data) {
-      if (err) {
-        // log an error
-        console.log(util.inspect(err));
-      } else {
-        // Success
-        // console.log(util.inspect(data));
-      }
-    });
-  }
+  this.batchSend(currentCounterMetrics, namespace);
 
   // put all currently accumulated timer metrics into an array
   var currentTimerMetrics = [];
@@ -147,21 +168,7 @@ CloudwatchBackend.prototype.flush = function(timestamp, metrics) {
     }
   }
 
-  // send off the array (instead of one at a time)  
-  if (currentTimerMetrics.length > 0) {
-    this.cloudwatch.putMetricData({
-      MetricData: currentTimerMetrics,
-      Namespace: namespace
-    }, function(err, data) {
-      if (err) {
-        // log an error
-        console.log(util.inspect(err));
-      } else {
-        // Success
-        // console.log(util.inspect(data));
-      }
-    });
-  }
+  this.batchSend(currentTimerMetrics, namespace);
 
   // put all currently accumulated gauge metrics into an array
   var currentGaugeMetrics = [];
@@ -184,21 +191,7 @@ CloudwatchBackend.prototype.flush = function(timestamp, metrics) {
     });
   }
 
-  // send off the array (instead of one at a time)
-  if (currentGaugeMetrics.length > 0) {
-    this.cloudwatch.putMetricData({
-      MetricData: currentGaugeMetrics,
-      Namespace: namespace
-    }, function(err, data) {
-      if (err) {
-        // log an error
-        console.log(util.inspect(err));
-      } else {
-        // Success
-        // console.log(util.inspect(data));
-      }
-    });
-  }
+  this.batchSend(currentGaugeMetrics, namespace);
 
   // put all currently accumulated set metrics into an array
   var currentSetMetrics = [];
@@ -221,21 +214,7 @@ CloudwatchBackend.prototype.flush = function(timestamp, metrics) {
     });
   }
 
-  // send off the array (instead of one at a time)
-  if (currentSetMetrics.length > 0) {
-    this.cloudwatch.putMetricData({
-      MetricData: currentSetMetrics,
-      Namespace: namespace
-    }, function(err, data) {
-      if (err) {
-        // log an error
-        console.log(util.inspect(err));
-      } else {
-        // Success
-        // console.log(util.inspect(data));
-      }
-    });
-  }
+  this.batchSend(currentSetMetrics, namespace);
 };
 
 exports.init = function(startupTime, config, events) {