Python 3.12+ compatibility - module 'ssl' has no attribute 'wrap_socket' #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 For this, we need this merged ASAP too |
|
@henrys-cm or anyone at CM, could you please review this? This library doesn't work with Python 3.12+, which I assume is reasonably important. |
|
I've tried emailing the support to hopefully get some action on this. |
That can be added, although someone with knowledge of the codebase has to look at this. Like those |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ssl.wrap_socket was deprecated since Python 3.7 and remove in 3.12 so for it to work with 3.12 SSLContext.wrap_socket has to be used.
https://pradyunsg-cpython-lutra-testing.readthedocs.io/en/latest/whatsnew/3.12.html
Tested for my use case and it seems to be working fine, although did not test with self.key_file/self.cert_file set which were undefined (and None in some test).