Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow to pass clusterID as query param #7

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Allow to pass clusterID as query param #7

wants to merge 4 commits into from

Conversation

raphink
Copy link
Contributor

@raphink raphink commented Sep 2, 2024

Signed-off-by: Raphaël Pinson [email protected]

Vampouille
Vampouille reviewed Sep 3, 2024
View reviewed changes
main.go Show resolved Hide resolved
Vampouille
Vampouille reviewed Sep 3, 2024
View reviewed changes
main.go Outdated Show resolved Hide resolved
Vampouille
Vampouille requested changes Sep 3, 2024
View reviewed changes
Copy link
Member

@Vampouille Vampouille left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think something is wrong here :

	clusterID = os.Getenv("EKS_CLUSTER_ID")
	clusterID = values.Get("cluster_id")

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vampouille Vampouille Vampouille requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raphink @Vampouille