Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix unexpected client_info error #2481

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Fix unexpected client_info error #2481

merged 1 commit into from
Oct 24, 2024

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner marked this pull request as ready for review October 21, 2024 09:11
ger-benjamin
ger-benjamin approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the try/except the best approach ?
In my case, I've issue because somehow, the forwarded is empty and the dict(split...) can't work. And simple if "=" in forwarded: would be sufficient (instead of the try).

@sbrunner sbrunner force-pushed the fix-client-info branch 2 times, most recently from 4d495b9 to 66fc58f Compare October 24, 2024 08:33
@sbrunner sbrunner merged commit 797d38d into master Oct 24, 2024
7 checks passed
@sbrunner sbrunner deleted the fix-client-info branch October 24, 2024 09:35
@geo-ghci-int geo-ghci-int bot added this to the 6.1.0 milestone Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ger-benjamin ger-benjamin ger-benjamin approved these changes

@danduk82 danduk82 Awaiting requested review from danduk82

@gberaudo gberaudo Awaiting requested review from gberaudo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
6.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@sbrunner @ger-benjamin