Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Webcomponents]: Fix bug where gn-record-view stays empty #26

Merged
merged 1 commit into from
Jan 20, 2025

Conversation

cmoinier
Copy link
Contributor

Description

This PR fixes the bug where the gn-record-view stays empty in some cases. This was due to gn-ui-api-card needing the input "currentLink" in addition of "link", which was the only one passed down.

Quality Assurance Checklist

  • Commit history is devoid of any merge commits and readable to facilitate reviews
  • If new logic ⚙️ is introduced: unit tests were added
  • If new user stories 🤏 are introduced: E2E tests were added
  • If new UI components 🕹️ are introduced: corresponding stories in Storybook were created
  • If breaking changes 🪚 are introduced: add the breaking change label
  • If bugs 🐞 are fixed: add the backport <release branch> label
  • The documentation website 📚 has received the love it deserves

@cmoinier cmoinier changed the base branch from geocat to geocat-gpf January 17, 2025 16:20
Copy link
Contributor

Affected libs: api-repository, feature-catalog, feature-record, feature-router, feature-search, feature-map, feature-editor, feature-auth, ui-map, feature-dataviz,
Affected apps: geoadmin-demo, webcomponents, metadata-editor, datahub, demo, map-viewer, search, datafeeder,

  • 🚀 Build and deploy storybook and demo on GitHub Pages
  • 📦 Build and push affected docker images

Copy link
Member

@jahow jahow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@jahow jahow merged commit fc22ef3 into geocat-gpf Jan 20, 2025
5 of 6 checks passed
@jahow jahow deleted the fix-error-blank-record branch January 20, 2025 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants