feat: changes from review

camptocamp · Jun 27, 2024 · 6f877d1 · 6f877d1
1 parent cb83567
commit 6f877d1
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 7 deletions.
diff --git a/apps/datahub/src/app/dataset/dataset-information/dataset-information.component.html b/apps/datahub/src/app/dataset/dataset-information/dataset-information.component.html
@@ -17,12 +17,12 @@
     <div class="flex flex-col gap-2">
       <span class="font-semibold" translate="">mel.dataset.categories</span>
       <div class="flex gap-1 gap-x-2 flex-row flex-wrap">
-        @for(topic of displayCategories; track $index) {
+        @for(category of displayCategories; track $index) {
         <button
           class="mel-badge-primary truncate"
-          (click)="onInfoKeywordClick(topic)"
+          (click)="onCategoryKeywordClick(category)"
         >
-          {{ topic }}
+          {{ category }}
         </button>
         }
       </div>

diff --git a/apps/datahub/src/app/dataset/dataset-information/dataset-information.component.ts b/apps/datahub/src/app/dataset/dataset-information/dataset-information.component.ts
@@ -42,9 +42,7 @@ export class DatasetInformationComponent {
     return categoryKeywords?.map((keyword) => keyword.label)
   }
 
-  onInfoKeywordClick(keyword: string) {
-    this.routerFacade
-      ? this.routerFacade.updateSearch({ q: keyword })
-      : goFromHomeToSearch(keyword)
+  onCategoryKeywordClick(category: string) {
+    this.routerFacade.updateSearch({ q: category })
   }
 }