Merge pull request #65 from camptocamp/change-links-footer

[Dataset page] : Change footer links
camptocamp · May 7, 2024 · bc0c6ea · bc0c6ea
2 parents 9329a0f + 81d75ef
commit bc0c6ea
Show file tree

Hide file tree

Showing 2 changed files with 25 additions and 13 deletions.
diff --git a/apps/home-e2e/src/e2e/home.cy.ts b/apps/home-e2e/src/e2e/home.cy.ts
@@ -85,16 +85,24 @@ describe('home', () => {
       cy.get('@url').should('include', 'twitter')
       cy.get('@url').should('include', 'MetropoleLille')
     })
-    it('should display the partners icons', () => {
+    it('should display the partners icons as links', () => {
       cy.get('@footer')
         .children('footer')
         .first()
         .children('div')
         .first()
         .children('div')
         .eq(1)
-        .children('img')
+        .children('a')
         .should('have.length', 2)
+        .each((el, index) => {
+          const urls = [
+            'https://next-generation-eu.europa.eu/index_fr',
+            'https://www.economie.gouv.fr/plan-de-relance',
+          ]
+          cy.wrap(el).should('have.attr', 'href', urls[index])
+          cy.wrap(el).should('have.attr', 'target', '_blank')
+        })
     })
     it('should have a button to the newsletter subscription', () => {
       cy.get('@footer')

diff --git a/libs/mel/src/lib/footer/mel-datahub-footer.component.html b/libs/mel/src/lib/footer/mel-datahub-footer.component.html
@@ -82,7 +82,7 @@
         </li>
         <li class="flex">
           <a
-            href="https://www.youtube.com/channel/UC8u2Ore30NYveCLHzj82DRA"
+            href="https://youtube.com/@metropoledelille"
             target="_blank"
             class="hover:outline-offset-4 hover:border-b-2 hover:border-red-600"
           >
@@ -129,16 +129,20 @@
       </ul>
     </div>
     <div class="flex flex-row items-center flex-wrap">
-      <img
-        class="h-20 mr-8"
-        src="{{ iconsUrl }}finance_ue.png"
-        [alt]="'mel.common.footer.logo.financeUE' | translate"
-      />
-      <img
-        class="h-24"
-        src="{{ iconsUrl }}france_relance.png"
-        [alt]="'mel.common.footer.logo.franceRelance' | translate"
-      />
+      <a href="https://next-generation-eu.europa.eu/index_fr" target="_blank">
+        <img
+          class="h-20 mr-8"
+          src="{{ iconsUrl }}finance_ue.png"
+          [alt]="'mel.common.footer.logo.financeUE' | translate"
+        />
+      </a>
+      <a href="https://www.economie.gouv.fr/plan-de-relance" target="_blank">
+        <img
+          class="h-24"
+          src="{{ iconsUrl }}france_relance.png"
+          [alt]="'mel.common.footer.logo.franceRelance' | translate"
+        />
+      </a>
     </div>
     <div class="flex flex-row items-center">
       <span class="text-xs leading-3 mr-10" translate=""