feat(keywords): Use category keywords, change category filter, change date filter #71
Conversation
to categories (first level thesaurus), change keywords on search card to second level thesaurus keywords
extend FieldsService to support categories
Angi-Kinas
force-pushed
the
change-keywords-to-categories-dataset-page
branch
from
85dfdc3
to
606bfdf
Compare
revisionYearForResource
Angi-Kinas
changed the title
There was a problem hiding this comment.
Thanks for this nice feature @Angi-Kinas and for making the date filtering consistent!
Everything works well on my side. I guess it's normal that we currently only have three values in the categories filter on integration, since not more terms of the thesaurus have been attached to records yet?
| }) | ||
| ) | ||
| searchConfig = [ | ||
| 'categoryKeyword', |
There was a problem hiding this comment.
Just wondering if category would be sufficient here, as it is also part of the URL and would align with the filter label. Even though I agree that categoryKeyword is technically more explicit. I let you judge.
There was a problem hiding this comment.
Good point 👍 , I think both works, but when I look at gn-ui where the inspireKeyword was extracted in a similar way, I will keep the Keyword-Suffix. So I hope when we will touch this in the future this will be more explicit and we know that in this case the categories come from the categories thesaurus.
|
@tkohr Yes there are only these three values because others were not used in the records yet (afaik). |
This PR changes the keywords in the information block of the dataset page to use the keywords from the categories thesaurus (first level) and it changes the keywords on the search card to NOT use the categories thesaurus keywords, but all others (second level).
It also updates the "topic/thématique" filter to become a "category/categorie" filter and the date filter uses now the
revisionYearForResourceas the filter instead of the publication year.