-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Search page] : Pagination #89
Conversation
6afb774
to
7606b1d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @cmoinier for implementing the pagination, it looks really cool! :)
I just see a small improvement in the the font-weight of the "previous" and "next" button and their respective icons.
The rest would be a nice to have :-)
apps/datahub/src/app/search/search-results/search-results.component.html
Outdated
Show resolved
Hide resolved
apps/datahub/src/app/search/search-results/search-results.component.ts
Outdated
Show resolved
Hide resolved
libs/mel/src/lib/pagination-buttons/pagination-buttons.component.html
Outdated
Show resolved
Hide resolved
libs/mel/src/lib/pagination-buttons/pagination-buttons.component.html
Outdated
Show resolved
Hide resolved
libs/mel/src/lib/pagination-buttons/pagination-buttons.component.html
Outdated
Show resolved
Hide resolved
…platform into paginate-search-page
@cmoinier thank you for the adaptions! Also something I discovered (by mistake). If you only have one page, but in the url you use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for implementing my suggestions @cmoinier
LGTM 👍
Description
This PR adds a pagination component to the search page.
To test
With the local dump, you will need to decrease the pageSize in SearchResultsComponent to 2-3 in order to see the pagination work properly. It is set to 18 because the ticket asked for a display of 3x6 cards.