[Search] Rework filter area #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoinier
force-pushed
the
rework-filter-area
branch
from
2595ec8
to
7177e06
Compare
cmoinier
force-pushed
the
rework-filter-area
branch
from
35b78fb
to
c4b10d8
Compare
tkohr
reviewed
Jul 10, 2024
...p/search/search-filters/mel-datahub-dropdown-range/mel-datahub-dropdown-range.component.html
Show resolved
Hide resolved
...app/search/search-filters/mel-datahub-dropdown-range/mel-datahub-dropdown-range.component.ts
Outdated
Show resolved
Hide resolved
apps/datahub/src/app/search/search-filters/search-filters.component.html
Show resolved
Hide resolved
cmoinier
force-pushed
the
rework-filter-area
branch
3 times, most recently
from
27f820b
to
5d7ea7e
Compare
cmoinier
force-pushed
the
rework-filter-area
branch
from
68c6645
to
56c2536
Compare
tkohr
approved these changes
Jul 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR reworks the filter area on the search page.
It now displays only 3 filters in "normal" mode, and all the filters, including two new ones (quality score and territories) on the "expanded" version. It also adds a reset button.
Since one of the new filters (quality score) is a range, a new dropdown selector component for number ranges is introduced.
Screenshots