[Upgrade]: Upgrade gn-ui & add filters and sharing options #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmoinier
force-pushed
the
upgrade-with-prodocuer-and-maps
branch
from
ebd4f94
to
75c4380
Compare
cmoinier
force-pushed
the
upgrade-with-prodocuer-and-maps
branch
from
15f8668
to
0249b9f
Compare
Angi-Kinas
reviewed
Jul 15, 2024
apps/datahub/src/app/dataset/dataset-visualisation/dataset-visualisation.component.ts
Show resolved
Hide resolved
Angi-Kinas
approved these changes
Jul 15, 2024
There was a problem hiding this comment.
Thank you @cmoinier for implementing this.
I think it is good to go, but I would revert the changes in the constructor of the dataset-visualisation component and only keep the initial value of selectedView.
apps/datahub/src/app/dataset/dataset-visualisation/dataset-visualisation.component.ts
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR upgrades gn-ui and implements three new features :
Must do npm install & use prod URL in proxy-config to test