Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AC#1121: Any column contains filter #419

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

hermann-p
Copy link
Contributor

  • I gave the PR a meaningful name
  • I checked that the correct target branch is selected
  • I rebased the branch on the target branch and it can be merged
  • I ran the linter and it did pass
  • I checked for unused code / dead code / debug code
  • I checked that variables/functions have meaningful names
  • I checked that the behaviour is as the documentation/task describes and I tested it
  • I updated the docs / specifications if possible
  • I could explain all that code when someone wakes me up at 3am
  • I checked that the code considers failures and not just the happy path
  • There are no new dependencies OR I listed them and explained them below
  • PR introduces no breaking changes OR I listed them and described them below
  • I added/updated tests for new/modified unit-testable functions/helpers
  • I ran the tests and they did pass

@hermann-p hermann-p changed the title Ac1121/any column contains Ac1121: Any column contains filter Jan 16, 2025
@hermann-p hermann-p changed the title Ac1121: Any column contains filter AC#1121: Any column contains filter Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant