Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove internal artifacts from dependencies #2751

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

dlavrenuek
Copy link
Contributor

@dlavrenuek dlavrenuek commented Oct 16, 2023

Description

This PR removes two internal artifacts from the list of dependencies in Identity, these are part of Identity itself.

When should this change go live?

The change can go live any time.

  • This change is not yet live and should not be merged until {ADD_DATE} (apply hold label or convert to draft PR)?
  • There is no urgency with this change.
  • This change or page is part of a marketing blog, conference talk, or something else on a schedule.
  • This functionality is already available but undocumented.
  • This is a bug fix or security concern.

PR Checklist

  • I have added changes to the relevant /versioned_docs directory, or they are not for an already released version.
  • I have added changes to the main /docs directory (aka /next/), or they are not for future versions.
  • My changes require an Engineering review, and I've assigned an engineering manager or tech lead as a reviewer, or my changes do not require an Engineering review.
  • My changes require a technical writer review, and I've assigned @christinaausley as a reviewer, or my changes do not require a technical writer review.

@dlavrenuek dlavrenuek added the component:identity Issues related with Identity project label Oct 16, 2023
Copy link
Contributor

@Ben-Sheppard Ben-Sheppard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - we should also look to follow up with a change in the Identity code to remove these from the generated dependency lists

@dlavrenuek dlavrenuek merged commit 81591fe into main Oct 16, 2023
10 checks passed
@dlavrenuek dlavrenuek deleted the identity/update-dependencies branch October 16, 2023 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:identity Issues related with Identity project
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants