Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update supported-environments.md #4010

Merged
merged 4 commits into from
Aug 5, 2024
Merged

Conversation

toco-cam
Copy link
Member

@toco-cam toco-cam commented Jul 2, 2024

Description

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • There is no urgency with this change and can be released at any time.

PR Checklist

  • My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

@toco-cam toco-cam requested a review from MaxTru July 2, 2024 15:47
Copy link
Contributor

github-actions bot commented Jul 2, 2024

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.5/.

  • docs/reference/supported-environments.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

@christinaausley christinaausley added the component:docs Documentation improvements, including new or updated content label Jul 3, 2024
@MaxTru MaxTru requested a review from igpetrov July 4, 2024 11:25
@MaxTru
Copy link
Contributor

MaxTru commented Jul 4, 2024

Hi @igpetrov,

see request from Tobias to update the docs. Are we already confident with that OS bump?

@igpetrov
Copy link
Contributor

igpetrov commented Jul 4, 2024

Hi @MaxTru
I saw the request. We are not confident yet with all versions provided. For now, minimal version I checked was 2.9, I didn't cover 2.11 and 2.13. Let me prioritize this task and I can report next week on it. Would that work?

igpetrov
igpetrov previously approved these changes Jul 4, 2024
Copy link
Contributor

@igpetrov igpetrov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@toco-cam

LGTM. I am thinking whether it makes sense to call out 2.9.x+ instead of 2.9; 2.11; 2.13+ which sounds the same to me? Also, was there any agreement that we start from 2.9?

@toco-cam
Copy link
Member Author

toco-cam commented Jul 4, 2024

Hello @igpetrov,

Also, was there any agreement that we start from 2.9?
We do not have good customer feedback on how long we should support an environment. The fact that AWS is not retiring environments does not make it easier.

As the minor versions are upward compatible, "x.+," it is better for customers to support older versions as they are not forced to upgrade. Engineering requested changing to 2.9+ to use new features and reduce test efforts.

Regards Tobias

@igpetrov
Copy link
Contributor

Hi @christinaausley @toco-cam,

Can we merge this one? Let's give the Customers as much time as we can to discover this. Thank you!

@akeller akeller requested a review from a team July 19, 2024 18:05
@akeller
Copy link
Member

akeller commented Jul 19, 2024

@igpetrov, I added @camunda/tech-writers as reviewers so we can merge this. I also updated the PR description based on what I see changed in the PR - no backporting required as this change is just for /next/ or the preview for 8.6. If that's incorrect, please speak up!

@christinaausley christinaausley dismissed stale reviews from igpetrov and themself via d8c47ce July 19, 2024 19:35
@igpetrov
Copy link
Contributor

@akeller

no backporting required as this change is just for /next/ or the preview for 8.6. If that's incorrect, please speak up!

That's correct, it's for /next to let the Customers get familiar with the change. The actual change will happen in 8.6.

igpetrov
igpetrov previously approved these changes Jul 22, 2024
@toco-cam
Copy link
Member Author

@toco-cam
Copy link
Member Author

@MaxTru

Igor suggested:

I am thinking whether it makes sense to call out 2.9.x+ instead of 2.9; 2.11; 2.13+

We had a brief call, and as we do not have dedicated test coverage for the different versions 2.9, 2.11, and 2.13, there is, IMO no value in calling them out specifically. WDYT?

@MaxTru
Copy link
Contributor

MaxTru commented Jul 23, 2024

@MaxTru

Igor suggested:

I am thinking whether it makes sense to call out 2.9.x+ instead of 2.9; 2.11; 2.13+

We had a brief call, and as we do not have dedicated test coverage for the different versions 2.9, 2.11, and 2.13, there is, IMO no value in calling them out specifically. WDYT?

I agree. Let's go for 2.9.x+.

@akeller
Copy link
Member

akeller commented Jul 25, 2024

@MaxTru
Igor suggested:

I am thinking whether it makes sense to call out 2.9.x+ instead of 2.9; 2.11; 2.13+

We had a brief call, and as we do not have dedicated test coverage for the different versions 2.9, 2.11, and 2.13, there is, IMO no value in calling them out specifically. WDYT?

I agree. Let's go for 2.9.x+.

@christinaausley based on this comment, can you adjust this PR for @toco-cam so we can get it merged?

@christinaausley christinaausley dismissed stale reviews from igpetrov and themself via e9af67f July 26, 2024 15:26
Copy link
Contributor

@christinaausley christinaausley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done @akeller 👍

Copy link
Member

@akeller akeller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Based on the convo in this PR, I believe this reflects the intended change - approving.

toco-cam and others added 4 commits August 5, 2024 11:24
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@igpetrov igpetrov force-pushed the change-docs-supported-environments branch from e9af67f to eb580ab Compare August 5, 2024 08:24
@igpetrov igpetrov merged commit 536c5ff into main Aug 5, 2024
7 checks passed
@igpetrov igpetrov deleted the change-docs-supported-environments branch August 5, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:docs Documentation improvements, including new or updated content
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants