Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update node-js-sdk.md #4026

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Update node-js-sdk.md #4026

merged 2 commits into from
Jul 17, 2024

Conversation

jwulf
Copy link
Member

@jwulf jwulf commented Jul 11, 2024

A customer reached out to support because they used the Docker profile with no Identity and the connection fails because we assume OAuth.

This patch informs the users how to turn OAuth off.

Description

Ref: https://jira.camunda.com/browse/SUPPORT-22663

When should this change go live?

  • This is a bug fix, security concern, or something that needs urgent release support.
  • This is already available but undocumented and should be released within a week.
  • This on a specific schedule and the assignee will coordinate a release with the DevEx team. (apply hold label or convert to draft PR)
  • This is part of a scheduled alpha or minor. (apply alpha or minor label)
  • [ X ] There is no urgency with this change and can be released at any time.

PR Checklist

  • [ X ] My changes are for an already released minor and are in /versioned_docs directory.
  • My changes are for the next minor and are in /docs directory (aka /next/).

A customer reached out to support because they used the Docker profile with no Identity and the connection fails because we assume OAuth.

This patch informs the users how to turn OAuth off.
@jwulf jwulf requested review from pepopowitz and a team July 11, 2024 03:41
Copy link
Contributor

👋 🤖 🤔 Hello! Did you make your changes in all the right places?

These files were changed only in versioned_docs/version-8.5/. You might want to duplicate these changes in docs/.

  • versioned_docs/version-8.5/apis-tools/node-js-sdk.md

You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines.

Copy link
Collaborator

@pepopowitz pepopowitz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, except that I think the bot requesting corresponding changes in docs/ is accurate. We should apply the update to version next, in addition to 8.5, to carry it forward into new releases.

@jwulf
Copy link
Member Author

jwulf commented Jul 15, 2024

This looks good to me, except that I think the bot requesting corresponding changes in docs/ is accurate. We should apply the update to version next, in addition to 8.5, to carry it forward into new releases.

Is that #4027?

@pepopowitz
Copy link
Collaborator

This looks good to me, except that I think the bot requesting corresponding changes in docs/ is accurate. We should apply the update to version next, in addition to 8.5, to carry it forward into new releases.

Is that #4027?

Yes! Sorry, I didn't realize there was a second associated PR.

pepopowitz
pepopowitz previously approved these changes Jul 16, 2024
@akeller akeller merged commit 02182da into main Jul 17, 2024
7 checks passed
@akeller akeller deleted the jwulf-patch-1 branch July 17, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

5 participants