-
Notifications
You must be signed in to change notification settings - Fork 182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental: SAP documentation #4267
base: experimental-structure-PR
Are you sure you want to change the base?
Conversation
👋 🤖 🤔 Hello! Did you make your changes in all the right places? These files were changed only in docs/. You might want to duplicate these changes in versioned_docs/version-8.6/.
You may have done this intentionally, but we wanted to point it out in case you didn't. You can read more about the versioning within our docs in our documentation guidelines. |
@vobu here is a docs POC for you to think about where we can place the SAP content. |
thank you! will add on top of this PR with the SAP Integration documentation. |
@toco-cam Do you have any comments on the layout/formatting of these files? Is there any additional information you are expecting to be added with https://github.com/camunda/product-hub/issues/2415? @vobu Are you finished adding documentation to this PR? If so, I'll move this out of draft and give it a full review. |
not yet - docs for RFC connector and the BTP Integration are yet to get in there. Will be finished in cw 40 (Oct 4) the latest. Does that still give you enough time to overhaul until CCon NY? |
@vobu Sounds great! Thanks for the update. |
Hi @vobu -- just let me know when you are ready for final review here before CCon 👍 |
yes, will do as soon as I have more stuff in. Some friendly fire these days, so docs got delayed on my end. Will have finished next week Weg THE LATEST, pinky-promise-swear |
Removing |
Adding the deploy label back! Also, thanks for the status updates on this PR. |
I'll have a look at this today @vobu -- thank you for your effort on this! |
docs/guides/sap/btp-integration.md
Outdated
|
||
> [!IMPORTANT] | ||
> | ||
> The BTP integration is in alpha phase available upon request - please use the https://camunda.com/contact to get in touch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this an alpha feature, or an experimental feature like RPA? See this PR for context.
I have cleaned this up as a baseline, and I'm going to give this a second, more in-depth technical review tomorrow, but would be nice to have another @camunda/tech-writers look at this. Let me know if this is meant to be an experimental feature or an alpha feature, and I'll get this routed to the experimental feature PR and update the sidebar. |
Thanks for sweeping through!
this is an alpha release, not experimental any more :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried not to get too hands-on with edits here, as this is still in flux, but left some comments that where the instructions/descriptions seemed a little unclear. I'd be happy to look over this to offer a more in-depth review at some point, too; I think my biggest takeaways are breaking down or numbering some of the larger sections for more direct action, and if the term for BTP should be "SAP BTP" throughout.
@christinaausley please rename this PR if you are moving forward with it. The branch name is fine, but the PR title "POC: SAP guides" isn't intuitive enough. |
Co-authored-by: Cole Isaac <[email protected]>
Co-authored-by: Cole Isaac <[email protected]>
Co-authored-by: Cole Isaac <[email protected]>
docs/guides/sap/odata-connector.md
Outdated
@@ -0,0 +1,170 @@ | |||
--- | |||
id: odata-connector |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If these are indeed alpha, could add these Connectors to https://docs.camunda.io/docs/next/components/connectors/out-of-the-box-connectors/available-connectors-overview/.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes - but they need to be run in "hybrid" mode, on the SAP BTP of the customer. We don't run them in SaaS or on any SM k8s
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note to myself to add something on this once merged into the main PR and I can properly route to these links.
Hi all -- this is ready for a final approval to merge into the experimental structure PR, which will also get a final approval before going into |
🚧 The preview environment for the commit ba10a63 is being built. This usually takes 15-20 minutes. |
Description
When should this change go live?
hold
label or convert to draft PR)PR Checklist
/versioned_docs
directory./docs
directory (aka/next/
).