Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add bpmnlint recommended rules built-in #3289

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

@bpmn-io-tasks bpmn-io-tasks bot added the in progress Currently worked on label Nov 9, 2022
@nikku
Copy link
Member Author

nikku commented Nov 21, 2022

CC @YanaSegal

@nikku
Copy link
Member Author

nikku commented Nov 21, 2022

UI improvement we discussed already documented via https://github.com/bpmn-io/internal-docs/issues/665 CC @YanaSegal.

@nikku nikku added this to the M60 milestone Dec 2, 2022
@nikku nikku added the ready Ready to be worked on label Dec 4, 2022 — with bpmn-io-tasks
@nikku nikku removed the in progress Currently worked on label Dec 4, 2022
@nikku nikku added the backlog Queued in backlog label Jan 5, 2023 — with bpmn-io-tasks
@nikku nikku removed the ready Ready to be worked on label Jan 5, 2023
@nikku nikku modified the milestones: M60, M61 Jan 5, 2023
@nikku nikku modified the milestones: M61, M62 Feb 2, 2023
@nikku
Copy link
Member Author

nikku commented Feb 7, 2023

I've tried to push out an initial version of this thing as a preview, hidden behind a feature toggle. Unfortunately I failed in the timebox I put for myself.

What I wanted to accomplish:

if (Flags.get('bpmnlint-recommended-rules', true)) {
  registerClientPlugin(recommendedRules, 'lintRules.bpmn');
  registerClientPlugin(recommendedRules, 'lintRules.cloud-bpmn');
}

Why this failed: We eagerly load all internal plug-ins and cannot use flags that early in the resolution. We could load plug-ins after flags (and meta-data) are initialized; that would be my expected behavior. But given how we currently structure things that is not a quick task.

@philippfromme
Copy link
Contributor

We could load plug-ins after flags (and meta-data) are initialized

I agree with that.

@CatalinaMoisuc CatalinaMoisuc added the ready Ready to be worked on label Mar 7, 2023 — with bpmn-io-tasks
@CatalinaMoisuc CatalinaMoisuc removed the backlog Queued in backlog label Mar 7, 2023
@nikku nikku modified the milestones: M62, M63 Mar 7, 2023
@nikku nikku modified the milestones: M63, M64 Apr 3, 2023
@nikku nikku added backlog Queued in backlog and removed ready Ready to be worked on labels Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Queued in backlog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants