Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: opensearch #127

Merged
merged 54 commits into from
Oct 11, 2024
Merged

feat: opensearch #127

merged 54 commits into from
Oct 11, 2024

Conversation

leiicamundi
Copy link
Contributor

@leiicamundi leiicamundi commented Sep 25, 2024

Implements: #362

New Features:

  • Added an OpenSearch module and GitHub Actions (GHA).
  • The cleanup script and action can now target specific modules.
  • The IRSA for AuroraDB now creates roles and access policies.
  • The README documents the usage of the IRSA setup.

Improvements:

  • The cleanup of dependencies in tests has been enhanced.
  • Deletion of the EBS storage class in the Terraform state no longer fails.
  • The IRSA for AuroraDB is now integrated into the tests.
  • Modules are now idempotent (tags and labels have been fixed).

TODOs:

  • Backup and monitoring tasks have been referenced for later work in #396.

@github-actions github-actions bot added the test label Sep 27, 2024
@leiicamundi leiicamundi self-assigned this Oct 3, 2024
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some smaller changes here and there.
Overall looks quite good! 🚀
I did not try it out but as you've written tests and they seemed to have made sense on utilizing the IRSA stuff 👍

@Langleu
Copy link
Member

Langleu commented Oct 10, 2024

Thinking a bit about the IRSA stuff and usefulness.

Let's say we have Operate, Tasklist, and Zeebe. All need access to OpenSearch but the default policy will only be working for one service account name, right?

Maybe we should mention that somewhere and an easy example on how they can configure the remaining ones to get access as well?
Maybe it's covered in the docs, only have insights based on this work.

@leiicamundi
Copy link
Contributor Author

Maybe it's covered in the docs; I only have insights based on this work.

It's indeed covered by the docs. I'll finish it ASAP so you can review it.
However, we will need one service account (SA) per service that needs to access the resource.

Thanks for the review! I've fixed most of the points, but the remaining ones are open questions. Let me think about them and get back to you.

@leiicamundi leiicamundi enabled auto-merge (squash) October 10, 2024 10:42
Copy link
Member

@Langleu Langleu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good from my side 🚀

@leiicamundi leiicamundi merged commit 2f35855 into main Oct 11, 2024
12 of 15 checks passed
@leiicamundi leiicamundi deleted the feature/opensearch branch October 11, 2024 06:10
@Langleu
Copy link
Member

Langleu commented Oct 11, 2024

oh wow, it merges it even with failures in the tests 🙈

@leiicamundi
Copy link
Contributor Author

Incredible... I'll have to fix the postgres job, it fails due to the switch on amazonlinix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants