Migrate to ESM, ESLint 9 and flat config #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippfromme
force-pushed
the
eslint-9
branch
from
4783017
to
d41e118
Compare
nikku
requested changes
Oct 6, 2024
philippfromme
force-pushed
the
eslint-9
branch
from
d41e118
to
c676346
Compare
philippfromme
changed the title
philippfromme
force-pushed
the
eslint-9
branch
2 times, most recently
from
4d806c0
to
4ff7efc
Compare
nikku
reviewed
Oct 8, 2024
nikku
reviewed
Oct 8, 2024
There was a problem hiding this comment.
Looks good from my end. One thing to consider: https://github.com/camunda/eslint-plugin-camunda-licensed/pull/13/files#r1791441298.
philippfromme
force-pushed
the
eslint-9
branch
2 times, most recently
from
c76ace3
to
b7d910a
Compare
nikku
requested changes
Oct 10, 2024
There was a problem hiding this comment.
Two small nit-picks, and potential to include bpmn-io/eslint-plugin-bpmn-io@55c414d.
package.json
Outdated
| ".": "./index.js", | ||
| "./configs/apache.js": "./configs/apache.js", | ||
| "./configs/commercial.js": "./configs/commercial.js", | ||
| "./configs/mit.js": "./configs/mit.js" |
There was a problem hiding this comment.
Suggested change
| "./configs/mit.js": "./configs/mit.js" | |
| "./configs/mit.js": "./configs/mit.js", | |
| "./package.json": "./package.json" |
nikku
reviewed
Oct 10, 2024
Related to bpmn-io/internal-docs#1042 BREAKING CHANGE: require eslint@9 (drop support for <= eslint@8) BREAKING CHANGE: use from ESM code-base, this module is ESM only BREAKING CHANGE: consume as ES module
philippfromme
force-pushed
the
eslint-9
branch
from
b7d910a
to
9c92528
Compare
nikku
changed the title
nikku
approved these changes
Oct 11, 2024
|
Thanks! I'll go ahead and merge + release this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the library to support eslint@9 (only), as eslint@8 is out of maintainance, as of October, 1st.
Turns this into an ESM only package, so consume it in
.mjsfiles in commonjs projects.Related to https://github.com/bpmn-io/internal-docs/issues/1042
Related to https://github.com/bpmn-io/internal-docs/issues/883