Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport 1.17] fix: substring() with exceeding length #896

Merged
merged 3 commits into from
Aug 29, 2024
Merged

[Backport 1.17] fix: substring() with exceeding length #896

merged 3 commits into from
Aug 29, 2024

Commits on Aug 23, 2024

  1. refactor: Migrate to new test style 

    (cherry picked from commit 315b732)
    @saig0
    saig0 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    c07b94a View commit details
    Browse the repository at this point in the history

  2. test: Verify substring() with exceeding length 

    Add a test case to verify that the function `substring()` can handle an exceeding length. If the given length is greater than the string then it returns the remaining characters from the start index.

(cherry picked from commit 9af6832)
    @saig0
    saig0 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    741a2d1 View commit details
    Browse the repository at this point in the history

  3. fix: substring() can handle exceeding length 

    If substring() is called with a given length that is greater than the string then it returns the remaining characters from the start index.

(cherry picked from commit 1f7478b)
    @saig0
    saig0 committed Aug 23, 2024
    Configuration menu
    Copy the full SHA
    87c8bae View commit details
    Browse the repository at this point in the history