[Backport 1.16] fix: Parse expression with NBSP character #915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add new test cases to verify that a NBSP and other space characters can be parsed. (cherry picked from commit f8f3f78)
Adjust the whitespace handling of the parser to ignore FEEL-specific whitespaces as defined in the DMN specification. The JavaWhitespace class worked very well because it supported also Java-like comments, as required by the DMN specification. Instead of adding additional whitespace rules for the individual parsers, extend the JavaWhitespace class by making a copy of it. This is less error-prone, easier to maintain, and more efficient. (cherry picked from commit 8b691b9)
(cherry picked from commit e965b88)
Some whitespace characters were treated as part of the list iteration variable name. As a result, the parsing failed because the keyword "in" was not found. Fix the parsing issue by excluding whitespace characters as part of the variable name. (cherry picked from commit 08ef5a4)
saig0
approved these changes
Aug 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Backport of #914 to
1.16.relates to #840
original author: @saig0