Skip to content

Commit

Permalink
WIP
Browse files Browse the repository at this point in the history
  • Loading branch information
philippfromme committed Sep 8, 2023
1 parent d87b5df commit 5bd5c82
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 7 deletions.
2 changes: 1 addition & 1 deletion lib/compiled-config.js
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ const rules = {
"camunda-compat/no-task-schedule": "error",
"camunda-compat/no-template": "error",
"camunda-compat/no-zeebe-properties": "error",
"camunda-compat/secrets": "error",
"camunda-compat/secrets": "warn",
"camunda-compat/sequence-flow-condition": "error",
"camunda-compat/signal-reference": "error",
"camunda-compat/start-form": "error",
Expand Down
8 changes: 4 additions & 4 deletions lib/utils/error-messages.js
Original file line number Diff line number Diff line change
Expand Up @@ -144,8 +144,8 @@ export function getErrorMessage(report, executionPlatform, executionPlatformVers
return getEventBasedGatewayTargetNotAllowedErrorMessage(report);
}

if (type === ERROR_TYPES.SECRET_EXPRESSION_INVALID) {
return getSecretExpressionInvalidErrorMessage(report);
if (type === ERROR_TYPES.SECRET_EXPRESSION_FORMAT_DEPRECATED) {
return getSecretExpressionFormatDeprecatedErrorMessage(report);
}

return message;
Expand Down Expand Up @@ -633,12 +633,12 @@ function getPropertyValueNotAllowedErrorMessage(report, executionPlatform, execu
return message;
}

function getSecretExpressionInvalidErrorMessage(report) {
function getSecretExpressionFormatDeprecatedErrorMessage(report) {
const { data } = report;

const { property } = data;

return `Property <${ property }> is not a valid secret`;
return `Property <${ property }> uses deprecated secret expression format secrets.SECRET, use {{secrets.SECRET}} instead`;
}

function getElementPropertyValueDuplicatedErrorMessage(report) {
Expand Down
4 changes: 2 additions & 2 deletions lib/utils/properties-panel.js
Original file line number Diff line number Diff line change
Expand Up @@ -298,8 +298,8 @@ export function getErrorMessage(id, report) {
return 'Cannot be an expression.';
}

if (data.type === ERROR_TYPES.SECRET_EXPRESSION_INVALID) {
return 'Is not a valid secret.';
if (data.type === ERROR_TYPES.SECRET_EXPRESSION_FORMAT_DEPRECATED) {
return 'Secret expression format deprecated.';
}

if (id === 'isExecutable') {
Expand Down

0 comments on commit 5bd5c82

Please sign in to comment.