Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only Display Errors in Properties Panel #86

Merged
merged 4 commits into from
Sep 25, 2023
Merged

Only Display Errors in Properties Panel #86

merged 4 commits into from
Sep 25, 2023

Conversation

philippfromme
Copy link
Collaborator

@philippfromme philippfromme commented Sep 22, 2023

@philippfromme philippfromme marked this pull request as ready for review September 25, 2023 08:53
@bpmn-io-tasks bpmn-io-tasks bot added needs review Review pending and removed in progress Currently worked on labels Sep 25, 2023
Copy link
Member

@nikku nikku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing (to my knowledge) - Test to verify warn does not propagate to properties panel.

@bpmn-io-tasks bpmn-io-tasks bot added in progress Currently worked on and removed needs review Review pending labels Sep 25, 2023
@philippfromme
Copy link
Collaborator Author

Missing (to my knowledge) - Test to verify warn does not propagate to properties panel.

See https://github.com/camunda/linting/pull/86/files#diff-9e46d7301b89e189b8ecc9b3149b778ce3707b220ab9e243e0ce07735d02fc67R1783.

@@ -63,7 +63,7 @@ describe('utils/error-messages', function() {
const errorMessage = getErrorMessage(report, 'Camunda Cloud', executionPlatformVersion);

// then
expect(errorMessage).to.equal('A <Signal Start Event> in a <Sub Process> is not supported by Camunda 8.2');
expect(errorMessage).to.equal('A <Signal Start Event> in a <Sub Process> is only supported by Camunda 8.3 or newer');
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@merge-me merge-me bot merged commit 641bcbe into main Sep 25, 2023
3 checks passed
@merge-me merge-me bot deleted the secrets-info branch September 25, 2023 09:22
@bpmn-io-tasks bpmn-io-tasks bot removed the in progress Currently worked on label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants