display search result with a tree #1
Conversation
It's a bit tricky but I think I solved the issue I mentioned
|
Florent-Bouisset
force-pushed
the
feat/search-result-indented
branch
from
1432007 to
f9aa2ea
Compare
Florent-Bouisset
force-pushed
the
feat/search-result-indented
branch
2 times, most recently
from
7559523 to
dbd7f32
Compare
Florent-Bouisset
force-pushed
the
feat/search-result-indented
branch
from
dbd7f32 to
7a6df87
Compare
| return r.item.h2 === undefined; | ||
| }); | ||
| if (topSection === undefined) { | ||
| const fakeH1 = structuredClone(value[0]); |
There was a problem hiding this comment.
I've no idea what we're trying to do there with those fakeH1 = ... (fakeH1 is an object?), it may need comments
| } | ||
|
|
||
| for (const value of Object.values(h1Sections)) { | ||
| const topSection = value.find((r) => { |
There was a problem hiding this comment.
Comments of that function says that a top section is h1 but here apparently it's h2, I'm lost
| @@ -439,6 +439,7 @@ function initializeSearchEngine() { | |||
| anchorH3: elt.anchorH3, | |||
| }); | |||
| pageIndex.push({ | |||
| file: res[i].file, | |||
There was a problem hiding this comment.
It's already present in searchIndexLinks no?
There was a problem hiding this comment.
Yes but If I don't add it there, there is no way to distinguish if 2 items come from the same page
There was a problem hiding this comment.
To me the id property is supposed to make the link between the two or I miss something?
| } | ||
| // Create the h1 key | ||
| if (!grouping[item.file][item.h1]) { | ||
| grouping[item.file][item.h1] = {}; |
There was a problem hiding this comment.
So from here we consider that h1 cannot be undefined?
| @@ -478,6 +479,8 @@ function initializeSearchEngine() { | |||
| return searchState.promise; | |||
| } | |||
|
|
|||
| const __DEFAULT_SYMBOL__ = Symbol("__DEFAULT__"); | |||
There was a problem hiding this comment.
Nice symbol usage, I like the idea.
We could add a comment
The idea of this proposal is to display results with a tree when searching on the doc.
There is an issue if the search result include a subsection but not the parent section, in this case the subsection is orphan, I'm not sure how to handle that.