Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 134 authorship #135

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Issue 134 authorship #135

wants to merge 7 commits into from

Conversation

turbomam
Copy link
Member

Change author from MAM to GV for issue #134

does Poetry read the package's author data from this setup.cfg? Or pyproject.toml?

turbomam and others added 5 commits September 23, 2021 16:25
test_ObservationSet.json untested
merging in main why7 comment needed?
does Poetry read the package's author data from this setup.cfg? Or pyproject.toml?
@turbomam
Copy link
Member Author

@gaurav @sujaypatil96 I'm ready for your review.

Somehow this authorship issue & PR got contaminated with some tests I wrote, but those are probably harmless and maybe even useful.

Copy link
Contributor

@sujaypatil96 sujaypatil96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran all your tests and everything passed seamlessly @turbomam. Thank you for the tests and also the modifications to the TOML file. Feel free to merge this PR when you're ready.🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants