Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: beta store redirects #1974

Merged
merged 1 commit into from
Aug 16, 2024
Merged

fix: beta store redirects #1974

merged 1 commit into from
Aug 16, 2024

Conversation

M7mdisk
Copy link
Contributor

@M7mdisk M7mdisk commented Aug 15, 2024

Done

  • manually init app instead of using store_base which doesnt read redirects properly

How to QA

  • make sure redirects defined in redirects.yaml work
  • make sure forms work (no CSFR issues)
  • click around, try to break stuff

Testing

  • This PR has tests
  • No testing required (explain why): no new features

Issue / Card

Fixes #

Screenshots

@webteam-app
Copy link

@M7mdisk M7mdisk force-pushed the redirects-beta branch 13 times, most recently from 757f23e to a6f4754 Compare August 16, 2024 05:42
Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.04%. Comparing base (d8cd01e) to head (a6f4754).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1974      +/-   ##
==========================================
+ Coverage   55.70%   56.04%   +0.34%     
==========================================
  Files          29       29              
  Lines        2156     2166      +10     
==========================================
+ Hits         1201     1214      +13     
+ Misses        955      952       -3     
Files Coverage Δ
webapp/app.py 64.51% <100.00%> (+5.76%) ⬆️
webapp/config.py 100.00% <100.00%> (ø)
webapp/decorators.py 71.42% <ø> (+4.76%) ⬆️

@M7mdisk M7mdisk changed the title Redirects beta fix: beta store redirects Aug 16, 2024
Copy link
Contributor

@abbiesims abbiesims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@M7mdisk M7mdisk merged commit b5e7b6e into main Aug 16, 2024
9 checks passed
@M7mdisk M7mdisk deleted the redirects-beta branch August 16, 2024 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants