fix: update tests that use setTimeout #1976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Demo
Jenkins 
demos.haus 
|
I ran the test-js job again and one of the tests failed |
abbiesims
force-pushed
the
WD-14170/fix-settimeout-testing
branch
4 times, most recently
from
264b2de
to
dbc6e16
Compare
abbiesims
force-pushed
the
WD-14170/fix-settimeout-testing
branch
from
dbc6e16
to
adaf7e8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Done
setTimeoutinjstests and refactors them to work usingawaitconsole.logetc)How to QA
Testing
Issue / Card
Fixes https://warthogs.atlassian.net/browse/WD-14170