Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: remove unused publisher code #1995

Merged
merged 1 commit into from
Sep 6, 2024
Merged

fix: remove unused publisher code #1995

merged 1 commit into from
Sep 6, 2024

Conversation

M7mdisk
Copy link
Contributor

@M7mdisk M7mdisk commented Sep 6, 2024 •
edited
Loading

Done

  • Remove access to non existing file which was causing JS errors when accessing /charms

How to QA

Testing

  • This PR has tests
  • No testing required (explain why): is bug fix

@webteam-app
Copy link

Demo

Jenkins

demos.haus

steverydz
steverydz approved these changes Sep 6, 2024
View reviewed changes
Copy link
Contributor

@steverydz steverydz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@M7mdisk M7mdisk merged commit c696d1d into main Sep 6, 2024
10 checks passed
@M7mdisk M7mdisk deleted the fix-list-error branch September 6, 2024 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steverydz steverydz steverydz approved these changes

Assignees
No one assigned
Labels
Review: Code +1 Review: QA +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@M7mdisk @webteam-app @steverydz