Skip to content

Commit

Permalink
remove clean up of channel signs, since we already use PR number (#93)
Browse files Browse the repository at this point in the history
revert PR #91

there is a side effect when we clean dots in the track number, eg 2.0/stable becomes 20/stable
  • Loading branch information
beliaev-maksim authored Mar 27, 2023
1 parent 65ee829 commit e60e65a
Show file tree
Hide file tree
Showing 7 changed files with 7 additions and 21 deletions.
4 changes: 1 addition & 3 deletions dist/channel/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22854,14 +22854,12 @@ class Charmcraft {
// however, we expect charmcraft pack to always output one charm file.
const globber = yield glob.create('./*.charm');
const paths = yield globber.glob();
// filter all characters which are not letters, numbers or hyphens
const allowedChannel = channel.replace(/[^a-zA-Z0-9\-/]/gi, '');
const args = [
'upload',
'--format',
'json',
'--release',
allowedChannel,
channel,
paths[0],
...flags,
];
Expand Down
4 changes: 1 addition & 3 deletions dist/check-libraries/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -23047,14 +23047,12 @@ class Charmcraft {
// however, we expect charmcraft pack to always output one charm file.
const globber = yield glob.create('./*.charm');
const paths = yield globber.glob();
// filter all characters which are not letters, numbers or hyphens
const allowedChannel = channel.replace(/[^a-zA-Z0-9\-/]/gi, '');
const args = [
'upload',
'--format',
'json',
'--release',
allowedChannel,
channel,
paths[0],
...flags,
];
Expand Down
4 changes: 1 addition & 3 deletions dist/release-charm/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22946,14 +22946,12 @@ class Charmcraft {
// however, we expect charmcraft pack to always output one charm file.
const globber = yield glob.create('./*.charm');
const paths = yield globber.glob();
// filter all characters which are not letters, numbers or hyphens
const allowedChannel = channel.replace(/[^a-zA-Z0-9\-/]/gi, '');
const args = [
'upload',
'--format',
'json',
'--release',
allowedChannel,
channel,
paths[0],
...flags,
];
Expand Down
4 changes: 1 addition & 3 deletions dist/release-libraries/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -23077,14 +23077,12 @@ class Charmcraft {
// however, we expect charmcraft pack to always output one charm file.
const globber = yield glob.create('./*.charm');
const paths = yield globber.glob();
// filter all characters which are not letters, numbers or hyphens
const allowedChannel = channel.replace(/[^a-zA-Z0-9\-/]/gi, '');
const args = [
'upload',
'--format',
'json',
'--release',
allowedChannel,
channel,
paths[0],
...flags,
];
Expand Down
4 changes: 1 addition & 3 deletions dist/upload-bundle/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22925,14 +22925,12 @@ class Charmcraft {
// however, we expect charmcraft pack to always output one charm file.
const globber = yield glob.create('./*.charm');
const paths = yield globber.glob();
// filter all characters which are not letters, numbers or hyphens
const allowedChannel = channel.replace(/[^a-zA-Z0-9\-/]/gi, '');
const args = [
'upload',
'--format',
'json',
'--release',
allowedChannel,
channel,
paths[0],
...flags,
];
Expand Down
4 changes: 1 addition & 3 deletions dist/upload-charm/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -22953,14 +22953,12 @@ class Charmcraft {
// however, we expect charmcraft pack to always output one charm file.
const globber = yield glob.create('./*.charm');
const paths = yield globber.glob();
// filter all characters which are not letters, numbers or hyphens
const allowedChannel = channel.replace(/[^a-zA-Z0-9\-/]/gi, '');
const args = [
'upload',
'--format',
'json',
'--release',
allowedChannel,
channel,
paths[0],
...flags,
];
Expand Down
4 changes: 1 addition & 3 deletions src/services/charmcraft/charmcraft.ts
Original file line number Diff line number Diff line change
Expand Up @@ -193,14 +193,12 @@ class Charmcraft {
const globber = await glob.create('./*.charm');
const paths = await globber.glob();

// filter all characters which are not letters, numbers or hyphens
const allowedChannel = channel.replace(/[^a-zA-Z0-9\-/]/gi, '');
const args = [
'upload',
'--format',
'json',
'--release',
allowedChannel,
channel,
paths[0],
...flags,
];
Expand Down

0 comments on commit e60e65a

Please sign in to comment.