Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent the state doesn't be changed issue with NV driver (Bugfix) #1679

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hanhsuan
Copy link
Contributor

@hanhsuan hanhsuan commented Jan 13, 2025

Description

While cycle updating the configuration with NVIDIA (Xorg) devices, it might failed with GDBus.Error:org.freedesktop.DBus.Error.AccessDenied: The requested configuration is based on stale information, however user could use the gnome control center to change the same display configuration without any error. Therefore, get the current state before _apply_monitors_config in the cycle to avoid this issue.

Resolved issues

Documentation

Tests

Tested with the same script in #1576 on intel, AMD and NVIDIA devices.

@hanhsuan hanhsuan changed the title Prevent the state doesn't be changed issue with NV driver Prevent the state doesn't be changed issue with NV driver (Bugfix) Jan 13, 2025
Copy link

codecov bot commented Jan 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.00%. Comparing base (4305ba1) to head (e13bc31).
Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1679   +/-   ##
=======================================
  Coverage   48.99%   49.00%           
=======================================
  Files         372      372           
  Lines       40321    40322    +1     
  Branches     6811     6811           
=======================================
+ Hits        19757    19758    +1     
  Misses      19842    19842           
  Partials      722      722           
Flag Coverage Δ
checkbox-support 61.99% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hanhsuan hanhsuan force-pushed the fix_nv_dbus_state_issue branch from 810d44b to e13bc31 Compare January 14, 2025 00:37
@hanhsuan hanhsuan marked this pull request as ready for review January 14, 2025 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant