Automate wake-on-LAN tests (New) #1686
Conversation
please refer to wake-on-LAN-automatic-tests.md for more details Co-authored-by: hanhsuan <[email protected]>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1686 +/- ##
=======================================
Coverage 48.99% 48.99%
=======================================
Files 372 372
Lines 40321 40321
Branches 6811 6811
=======================================
Hits 19757 19757
Misses 19842 19842
Partials 722 722
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| imports: from com.canonical.plainbox import manifest | ||
| requires: | ||
| manifest.has_ethernet_adapter == 'True' | ||
| manifest.has_ethernet_wake_on_lan_support== 'True' |
There was a problem hiding this comment.
I would suggest we have a manifest about the WoL server has been setup or not.
There was a problem hiding this comment.
one more issue is that we uses the RTC to wakeup the system in case the WoL is not working, shall we also add a RTC wakeup manifest as well?
| test_start_time = float(get_timestamp(timestamp_file)) | ||
| actual_start_time = datetime.datetime.fromtimestamp(test_start_time) |
There was a problem hiding this comment.
I would suggest we move this part (convert the float variable to timestamp) to the get_timestamp function.
as it is the function to read the timestamp from specific file.
| system_back_time = float(get_suspend_boot_time(powertype)) | ||
| actual_back_time = datetime.datetime.fromtimestamp(system_back_time) |
There was a problem hiding this comment.
I have some concerns for this part.
first, I would suggest we seperate the get_suspend_boot_time into two functions.
e.g.
command = ["journalctl", "-b", "0", "--output=short-unix"]
result = subprocess.check_output(
command, shell=False, universal_newlines=True
)
logs = result.splitlines()
get_up_timestamp = get_wakeup_timestamp if powertype == "s3" else get_first_boot_timestamp
actual_back_time = get_up_timestamp(logs)
second, move the part that convert float variable into timestamp into get_wakeup_timestamp and get_first_boot_timestamp.
third, in current implementation, there's a risk that the scripts would crashed (get_suspend_boot_time would return None) when no wakupe message been found in get_suspend_boot_time.
| bring_up_system("rtc", delay * retry * 2) | ||
| logging.debug( | ||
| "set the rtcwake time: {} seconds ".format(delay * retry * 2) | ||
| ) |
There was a problem hiding this comment.
the scripts would raise SystemExit if configure the RTC wake failed, but it's a bit weird to me that we don't test WoL because of RTC wake is not working.
eugene-yujinwu
force-pushed
the
automate_wake-on-lan
branch
from
95d33ee to
abdf0d4
Compare
| from wol_server import ( | ||
| tasker_main, | ||
| send_wol_command, | ||
| is_pingable, | ||
| run_task, | ||
| ) |
There was a problem hiding this comment.
Since fastapi is imported at the top level inside wol_server, the patch needs to happen before the import. See test_gnome_monitor.py for an example.
Automate wake-on-LAN tests (New)
Description
We would like to automate the wake-on-LAN test instead of running manual tests for it.
Please refer to wake-on-LAN-automatic-tests.md in the commit for more details
Resolved issues
Make the Wake-on-LAN test from manual to automatic.
Documentation
wake-on-LAN-automatic-tests.md
Tests
"[wol_S3_auto] Both success": https://certification.canonical.com/submissions/status/300209
"[wol_S3_auto] Cannot connect to the WOL server" : https://certification.canonical.com/submissions/status/300211
"[wol_S3_auto] One of the WOL disabled" : https://certification.canonical.com/submissions/status/300210
"[wol_auto_test] One of NIC has wake-on-LAN issue" : https://certification.canonical.com/submissions/status/300212
"[wake-on-Lan] test for one NIC": https://certification.canonical.com/hardware/202406-34088/submission/408713/