compatible: Add arm64 support to build_charm.yaml and release_charm.yaml #141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
force-pushed
the
build-arm-2
branch
from
5b5c331
to
d7defa7
Compare
|
testing on https://github.com/canonical-test4/postgresql-k8s-operator/actions/runs/8050255568 (cannot test on canonical org since waiting for IS to add Azure runners) |
taurus-forever
approved these changes
Feb 26, 2024
dragomirp
reviewed
Feb 26, 2024
|
|
||
|
|
||
| class Architecture(str, enum.Enum): | ||
| X64 = "amd64" |
There was a problem hiding this comment.
Might be better to name it AMD64 to keep it consistent.
There was a problem hiding this comment.
X64 matches github naming
dragomirp
approved these changes
Feb 26, 2024
carlcsaposs-canonical
added a commit
that referenced
this pull request
Feb 29, 2024
…e format https://discourse.charmhub.io/t/charmcraft-bases-provider-support/4713 charmcraft.yaml bases with build-on are a singleton list of one dict, not a dict Follow up to #141 Encountered on https://github.com/canonical/postgresql-k8s-operator/actions/runs/8073677258/job/22057758552?pr=403
carlcsaposs-canonical
added a commit
that referenced
this pull request
Feb 29, 2024
…e format (#146) https://discourse.charmhub.io/t/charmcraft-bases-provider-support/4713 charmcraft.yaml bases with build-on are a singleton list of one dict, not a dict Follow up to #141 Encountered on https://github.com/canonical/postgresql-k8s-operator/actions/runs/8073677258/job/22057758552?pr=403
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uses spec (pending review) ST111 - Multi-architecture
upstream-sourcein charm OCI resourceshttps://docs.google.com/document/d/19pzpza7zj7qswDRSHBlpqdBrA7Ndcnyh6_75cCxMKSo/edit