Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

compatible: feat: expose ubuntu-version in build_charms_with_cache.yaml #53

Closed
wants to merge 1 commit into from

Conversation

DnPlas
Copy link

@DnPlas DnPlas commented Jun 26, 2023

Expose ubuntu-version as an input for running the workflow on a specific ubuntu version. This parameter is used in the runs-on field, and can be configured by other workflows.

Expose `ubuntu-version` as an input for running the workflow on
a specific ubuntu version. This parameter is used in the runs-on
field, and can be configured by other workflows.
@DnPlas DnPlas changed the title feat: expose ubuntu-version in build_charms_with_cache.yaml compatible: feat: expose ubuntu-version in build_charms_with_cache.yaml Jun 26, 2023
@carlcsaposs-canonical
Copy link
Contributor

Out of curiosity, can I ask what situation you're encountering where you'd like to change the runs-on version? (i.e. needing ubuntu-20.04, for self-hosted runners, etc.)

FYI the build job does not use charmcraft destructive mode, so it should be able to build on multiple Ubuntu versions

@DnPlas
Copy link
Author

DnPlas commented Jun 26, 2023

Out of curiosity, can I ask what situation you're encountering where you'd like to change the runs-on version? (i.e. needing ubuntu-20.04, for self-hosted runners, etc.)

FYI the build job does not use charmcraft destructive mode, so it should be able to build on multiple Ubuntu versions

Yes, our charms (charmed-kubeflow) for instance have base 20.04, and we needed to pin those versions in our ci. If no destructive mode is used, maybe we can avoid this parameter as the build should be agnostic to the Ubuntu version, as you say. Feel free to close this PR if the contribution doesn't make sense.

@carlcsaposs-canonical
Copy link
Contributor

The workflow should be able to build 20.04 charms while running on ubuntu-latest. We'll likely re-open this when we need to add support for self-hosted runners

Please re-open if you have any issues building 20.04 charms!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants