breaking(build_charms_with_cache.yaml): Remove charms output (JSON string of charms built)
#58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
requested review from
DnPlas,
taurus-forever and
shayancanonical
|
Example implementation (planning to move to reusable pytest plugin): canonical/mysql-k8s-operator#261 |
shayancanonical
approved these changes
Jul 20, 2023
carlcsaposs-canonical
force-pushed
the
remove-charms-built-output
branch
from
0b778ef
to
72ba2ba
Compare
…string of charms built) Instead of using the JSON string, integration tests should instead download the GitHub artifact and check if a *.charm file exists If there are multiple *.charm files in a directory, the integration test job should use an input to determine which *.charm file to select (example input: Ubuntu version) This change makes build_charms_with_cache.yaml more consistent/interchangeable with build_charm_without_cache_yaml
carlcsaposs-canonical
force-pushed
the
remove-charms-built-output
branch
from
72ba2ba
to
d68e205
Compare
taurus-forever
approved these changes
Jul 28, 2023
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of using the JSON string, integration tests should instead download the GitHub artifact and check if a *.charm file exists
If there are multiple *.charm files in a directory, the integration test job should use an input to determine which *.charm file to select (example input: Ubuntu version)
This change makes build_charms_with_cache.yaml more consistent/interchangeable with build_charm_without_cache.yaml