compatible: Add pytest-operator plugin for test grouping #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlcsaposs-canonical
force-pushed
the
pytest-plugin-groups
branch
from
05e5ab3
to
11f0291
Compare
carlcsaposs-canonical
requested review from
paulomach,
taurus-forever and
shayancanonical
|
Tested on canonical/mysql-operator#252 |
taurus-forever
approved these changes
Jul 28, 2023
|
|
||
| By default, [pytest-operator](https://github.com/charmed-kubernetes/pytest-operator) runs each test file (Python module) in a separate Juju model. Usually, on GitHub, each integration test file is run in parallel (on separate runners). | ||
|
|
||
| This plugin allows further parallelization—an individual test file can be split into multiple groups. Each group can run on a separate GitHub runner. |
carlcsaposs-canonical
force-pushed
the
pytest-plugin-groups
branch
from
3fc512c
to
39b567b
Compare
paulomach
reviewed
Jul 28, 2023
| filtered_items.append(function) | ||
| elif group_number == config.option.group: | ||
| filtered_items.append(function) | ||
| items[:] = filtered_items |
There was a problem hiding this comment.
curiosity: will not this just override items content? why not just
Suggested change
| items[:] = filtered_items | |
| items = filtered_items |
There was a problem hiding this comment.
I believe the suggested code will move the reference of items locally but will not replace the original list (and thus, not modify the items)
paulomach
approved these changes
Jul 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will be used in future integration test reusable workflow