Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom metrics #10

Closed
wants to merge 6 commits into from
Closed

Custom metrics #10

wants to merge 6 commits into from

Conversation

Deezzir
Copy link
Contributor

@Deezzir Deezzir commented Sep 10, 2024

  • Compiled a list of metrics that might be useful in production (can be extended anytime).
  • Added a fallback to use the custom list to the dcgm-exporter app.

@Deezzir Deezzir requested a review from a team as a code owner September 10, 2024 21:48
@Deezzir Deezzir changed the title Custom metrics list Custom metrics Sep 10, 2024
@Deezzir Deezzir requested a review from aieri September 10, 2024 22:56
snap/snapcraft.yaml Show resolved Hide resolved
Copy link
Contributor

@samuelallan72 samuelallan72 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good. The file structure is nicely readable, and we're going to be refactoring the exporter command soon anyway. Let's ship it. 😁

Copy link

@rgildein rgildein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought that we agree that custom metrics will go to the charm and not snap, or not?

@Deezzir
Copy link
Contributor Author

Deezzir commented Sep 12, 2024

I think we decided to leave them here for now

Copy link
Member

@gabrielcocenza gabrielcocenza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same impression as Robert that the custom metrics should happen at the charm. Moreover, I think this will require some logic at run_dcgm_exporter.sh that is current on #4 to detect if there is a .csv file (maybe be restrict with the naming of the file) and add the -f if necessary.

@Deezzir Deezzir closed this Sep 16, 2024
@Deezzir Deezzir deleted the metrics branch September 16, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants