-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Custom metrics #10
Custom metrics #10
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this looks good. The file structure is nicely readable, and we're going to be refactoring the exporter command soon anyway. Let's ship it. 😁
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought that we agree that custom metrics will go to the charm and not snap, or not?
I think we decided to leave them here for now |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have the same impression as Robert that the custom metrics should happen at the charm. Moreover, I think this will require some logic at run_dcgm_exporter.sh that is current on #4 to detect if there is a .csv
file (maybe be restrict with the naming of the file) and add the -f
if necessary.
dcgm-exporter
app.