-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat tab component #84
base: main
Are you sure you want to change the base?
Conversation
IMHO
|
Also, would you have any thoughts on using the html5 detail/summary tags ? |
Details/summary seems more appropriate for Accordion than Tabs I think. Especially if we want to keep an option to use tabs as a navigation (with links) instead of inline panel switcher. So having only the tab strip, without the panels themselves would not be possible with details element. |
Yes, I do agree we should treat
We can, and they are variable (for example the width and color of the thicker bottom border - so it can be changed or made invisible). But there is still a question of how much more options we want to give, that we don't use ourselves: do we want to allow other borders to be visible? border radius - just on top or all around? There may be many ways people may want tabs to look that we don't consider yet (based on our designs). |
Next step (based on comments above): Move Future (not in this PR):
|
Done
Open Questions
<Tab>
components are passed as children of<Tabs>