Improve dataflow when rendering config file. #178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chanchiwai-ray
requested review from
Pjack,
aieri,
agileshaw,
jneo8 and
rgildein
dashmage
approved these changes
Feb 29, 2024
This was referenced Mar 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,
service.ExporterTemplate.render_configdetermineREDFISH_ENABLE(jinja2) variable byget_hw_tool_white_list, but the same information is also retrieved incharm.HardwareObserverCharm._get_redfish_credsviabmc_hw_verifier. If the two does not match (e.g.bmc_hw_verifierdetermines it redfish is not available butget_hw_tool_white_listdetermines that redfish is available), it will cause issue mentioned in #130.This PR tries to remove the possibility that the two information is inconsistent by relying on single source of truth. Note, it might not solve #130, since the root cause is not clear, and it's not reproducible from my environement.