-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Type Hints as specified in is-charms-contributing-guide #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arturo-seijas
previously approved these changes
Mar 5, 2024
cbartz
reviewed
Mar 6, 2024
arturo-seijas
previously approved these changes
Mar 6, 2024
cbartz
previously approved these changes
Mar 6, 2024
yanksyoon
previously approved these changes
Mar 6, 2024
javierdelapuente
dismissed stale reviews from yanksyoon, cbartz, and arturo-seijas
via
March 6, 2024 13:45
6f2af57
Test coverage for 6f2af57
Static code analysis report
|
merkata
approved these changes
Mar 6, 2024
arturo-seijas
approved these changes
Mar 6, 2024
cbartz
reviewed
Mar 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable spec:
Overview
Add the type hints that are specified in the is-charms-contributing-guide.
Variables
chaos-*
are also removed from the integration test yaml file, as those input variables were deleted from operator-workflows and the pipeline was failing.Rationale
Juju Events Changes
Module Changes
Library Changes
Checklist
src-docs
urgent
,trivial
,complex
)