Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Type Hints as specified in is-charms-contributing-guide #12

Merged
merged 4 commits into from
Mar 6, 2024

Conversation

javierdelapuente
Copy link
Contributor

@javierdelapuente javierdelapuente commented Mar 5, 2024

Applicable spec:

Overview

Add the type hints that are specified in the is-charms-contributing-guide.

Variables chaos-* are also removed from the integration test yaml file, as those input variables were deleted from operator-workflows and the pipeline was failing.

Rationale

Juju Events Changes

Module Changes

Library Changes

Checklist

@javierdelapuente javierdelapuente marked this pull request as ready for review March 5, 2024 07:46
@javierdelapuente javierdelapuente requested a review from a team as a code owner March 5, 2024 07:46
arturo-seijas
arturo-seijas previously approved these changes Mar 5, 2024
src/charm.py Outdated Show resolved Hide resolved
arturo-seijas
arturo-seijas previously approved these changes Mar 6, 2024
cbartz
cbartz previously approved these changes Mar 6, 2024
yanksyoon
yanksyoon previously approved these changes Mar 6, 2024
Copy link

github-actions bot commented Mar 6, 2024

Test coverage for 6f2af57

Name           Stmts   Miss Branch BrPart  Cover   Missing
----------------------------------------------------------
src/charm.py      32      0      4      0   100%
----------------------------------------------------------
TOTAL             32      0      4      0   100%

Static code analysis report

Run started:2024-03-06 13:47:28.361838

Test results:
  No issues identified.

Code scanned:
  Total lines of code: 151
  Total lines skipped (#nosec): 0
  Total potential issues skipped due to specifically being disabled (e.g., #nosec BXXX): 0

Run metrics:
  Total issues (by severity):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
  Total issues (by confidence):
  	Undefined: 0
  	Low: 0
  	Medium: 0
  	High: 0
Files skipped (0):

@javierdelapuente javierdelapuente merged commit 59b6ac9 into main Mar 6, 2024
20 checks passed
@javierdelapuente javierdelapuente deleted the add-missing-mypy branch March 6, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants