Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Openstack overlay #12

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Add Openstack overlay #12

merged 4 commits into from
Dec 9, 2024

Conversation

HomayoonAlimohammadi
Copy link
Contributor

Overview

This PR adds overlay for Openstack. Loadbalancer relation is not yet finalized and it to be decided/implemented in the future.

@HomayoonAlimohammadi HomayoonAlimohammadi requested a review from a team as a code owner December 5, 2024 14:44
overlays/openstack.yaml Outdated Show resolved Hide resolved
overlays/openstack.yaml Outdated Show resolved Hide resolved
overlays/openstack.yaml Outdated Show resolved Hide resolved
overlays/openstack.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rid us of easyrsa

@HomayoonAlimohammadi
Copy link
Contributor Author

All done, thanks for the review @addyess!

overlays/openstack.yaml Outdated Show resolved Hide resolved
@HomayoonAlimohammadi
Copy link
Contributor Author

@addyess both PRs for kube control v2 and tls-certificates interface are merged, we should be good to go.

Copy link
Contributor

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alrighty, i'm so sorry - there are a few more issues here

overlays/openstack.yaml Outdated Show resolved Hide resolved
overlays/openstack.yaml Show resolved Hide resolved
overlays/openstack.yaml Outdated Show resolved Hide resolved
overlays/openstack.yaml Outdated Show resolved Hide resolved
Copy link
Contributor

@addyess addyess left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@addyess addyess merged commit 3efb558 into main Dec 9, 2024
5 checks passed
@addyess addyess deleted the KU-1999/add-openstack-overlay branch December 9, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants