Handle various microcluster ready endpoints #142
Conversation
addyess
force-pushed
the
akd/try-microcluster-endpoints
branch
from
01eed65 to
6141475
Compare
| Raises: | ||
| K8sdConnectionError: If the response is Not Found on all endpoints. | ||
| """ | ||
| ready_endpoints = ["/core/1.0/ready", "/cluster/1.0/ready"] |
There was a problem hiding this comment.
We'll try the "new one" first -- then back up with the old one
| if ex.code == 404: | ||
| logger.warning( | ||
| "Encountered 404 while checking if micro-cluster is ready @ %s: %s", | ||
| endpoint, | ||
| ex, | ||
| ) | ||
| # Try the next endpoint if the current one is not found | ||
| continue |
There was a problem hiding this comment.
k8sd responding with a 404 is its way of saying "I see that request -- but that doesn't exist". A clear sign we should try another endpoint!
There was a problem hiding this comment.
So... this may be misleading the user into thinking something is wrong with the code.
Could the log be modified to mention this could be normal and we're cycling through possible endpoints?
There was a problem hiding this comment.
Maybe Trying endpoint 1 of 2: ...
| not_found = InvalidResponseError(code=404, msg="Not Found") | ||
| mock_send_request.side_effect = [not_found, not_found] |
There was a problem hiding this comment.
A wise man once said...
two wrongs don't make a right, but three lefts do
| if ex.code == 404: | ||
| logger.warning( | ||
| "Encountered 404 while checking if micro-cluster is ready @ %s: %s", | ||
| endpoint, | ||
| ex, | ||
| ) | ||
| # Try the next endpoint if the current one is not found | ||
| continue |
There was a problem hiding this comment.
So... this may be misleading the user into thinking something is wrong with the code.
Could the log be modified to mention this could be normal and we're cycling through possible endpoints?
Overview
With the advent of v2 microcluster, the ready endpoint moved from
/cluster/1.0/readyto/core/1.0/readybecause changing endpoints is a totally natural thing to do for runDetails
404.K8sdConnectionErrorif we run out of endpoints to try