Integrate with cloud-provider and test with AWS #162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
license-eye has checked 107 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 41 | 1 | 65 | 0 |
Click to see the invalid file list
- charms/worker/k8s/src/cloud_integration.py
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
addyess
force-pushed
the
KU-2000/use-v2-kubecontrol
branch
from
acf7430 to
92566a6
Compare
addyess
commented
Nov 13, 2024
charms/worker/k8s/src/charm.py
Outdated
Comment on lines
500
to
503
| self.kube_control.set_dns_port(53) | ||
|
|
||
| self.kube_control.set_default_cni("") | ||
| self.kube_control.set_image_registry("rocks.canonical.com") |
There was a problem hiding this comment.
TODO: find better values for these
There was a problem hiding this comment.
license-eye has checked 108 files.
| Valid | Invalid | Ignored | Fixed |
|---|---|---|---|
| 43 | 1 | 64 | 0 |
Click to see the invalid file list
- charms/worker/k8s/tests/unit/test_cloud_integration.py
Use this command to fix any missing license headers
```bash
docker run -it --rm -v $(pwd):/github/workspace apache/skywalking-eyes header fix
</details>
57b8d28 to
fdc41e4
Compare
bschimke95
reviewed
Nov 18, 2024
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
addyess
force-pushed
the
KU-2000/use-v2-kubecontrol
branch
from
4733368 to
144ae04
Compare
|
Test coverage for 144ae04 Static code analysis report |
mateoflorido
approved these changes
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Make use of charmed-kubernetes/interface-kube-control#2 to support integration of the k8s operator with aws
Details