-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Share Kubernetes Version Through Relation Data #164
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work! Thanks a lot @mateoflorido! Overall LGTM, just some minor comments and questions. I also leave the approval to someone that actually knows something about k8s-operator :D
022c11d
to
ce65a3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty straight forward here. I have a few questions naturally
7028e7c
to
9d273a3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Its up to you to use ReconcilerError
or leave the asserts. whatever you think is cleaner
This comment was marked as resolved.
This comment was marked as resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Overview
Share the Kubernetes version through the Juju
cluster
relation databag.Rationale
To add the refresh mechanism, we need a way to share the installed k8s bversion of our nodes via relation data. This will help the charm determine if the cluster is ready for an upgrade to a new version. Currently, the charm is blocked if there's a version mismatch within the cluster. In future PRs, we will add mechanisms to deliver these upgrades.
Testing
The databag shows how the version is shared by the charm units, with the leader announcing the Kubernetes version in the application databag.