Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add node-labeling charm config using the LabelMaker library #23

Merged
merged 8 commits into from
Feb 22, 2024

Conversation

addyess
Copy link
Contributor

@addyess addyess commented Feb 12, 2024

Applicable spec: https://warthogs.atlassian.net/browse/KU-325

Overview

Allows for charm config to label worker and control-plane nodes

Rationale

Allows a juju administrator to specify certain node labels so that dependent workloads can run on properly labeled kubelets. Will need access to the kubeconfig via #22

Juju Events Changes

N/A

Module Changes

N/A

Library Changes

Addition of the node-label library

Checklist

@addyess addyess added the enhancement New feature or request label Feb 12, 2024
@addyess addyess requested a review from a team as a code owner February 12, 2024 22:33
@addyess addyess force-pushed the KU325/config-nodes-with-labels branch from a2caedb to 1ac2bf9 Compare February 13, 2024 14:01
Copy link
Contributor

@kwmonroe kwmonroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

charms/worker/k8s/requirements.txt Outdated Show resolved Hide resolved
@addyess addyess force-pushed the KU325/config-nodes-with-labels branch from 1845a70 to 7b0ee9b Compare February 20, 2024 21:25
@addyess addyess force-pushed the KU325/config-nodes-with-labels branch from e43ec0a to 6914a3d Compare February 21, 2024 14:36
@addyess addyess requested a review from kwmonroe February 21, 2024 14:36
@addyess addyess merged commit 03d491b into main Feb 22, 2024
21 checks passed
@addyess addyess deleted the KU325/config-nodes-with-labels branch February 22, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants