-
Notifications
You must be signed in to change notification settings - Fork 14
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add unit tests for local storage (#665)
- Loading branch information
1 parent
72808cd
commit 522a161
Showing
4 changed files
with
167 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,155 @@ | ||
| package localpv_test | ||
|
|
||
| import ( | ||
| "context" | ||
| "errors" | ||
| "testing" | ||
|
|
||
| . "github.com/onsi/gomega" | ||
| "k8s.io/utils/ptr" | ||
|
|
||
| "github.com/canonical/k8s/pkg/client/helm" | ||
| helmmock "github.com/canonical/k8s/pkg/client/helm/mock" | ||
| "github.com/canonical/k8s/pkg/k8sd/features/localpv" | ||
| "github.com/canonical/k8s/pkg/k8sd/types" | ||
| snapmock "github.com/canonical/k8s/pkg/snap/mock" | ||
| ) | ||
|
|
||
| func TestDisabled(t *testing.T) { | ||
| t.Run("HelmApplyFails", func(t *testing.T) { | ||
| g := NewWithT(t) | ||
|
|
||
| applyErr := errors.New("failed to apply") | ||
| helmM := &helmmock.Mock{ | ||
| ApplyErr: applyErr, | ||
| } | ||
| snapM := &snapmock.Snap{ | ||
| Mock: snapmock.Mock{ | ||
| HelmClient: helmM, | ||
| }, | ||
| } | ||
| cfg := types.LocalStorage{ | ||
| Enabled: ptr.To(false), | ||
| Default: ptr.To(true), | ||
| ReclaimPolicy: ptr.To("reclaim-policy"), | ||
| LocalPath: ptr.To("local-path"), | ||
| } | ||
|
|
||
| status, err := localpv.ApplyLocalStorage(context.Background(), snapM, cfg, nil) | ||
|
|
||
| g.Expect(err).To(MatchError(applyErr)) | ||
| g.Expect(status.Enabled).To(BeFalse()) | ||
| g.Expect(status.Message).To(ContainSubstring(applyErr.Error())) | ||
| g.Expect(status.Version).To(Equal(localpv.ImageTag)) | ||
| g.Expect(helmM.ApplyCalledWith).To(HaveLen(1)) | ||
|
|
||
| callArgs := helmM.ApplyCalledWith[0] | ||
| g.Expect(callArgs.Chart).To(Equal(localpv.Chart)) | ||
| g.Expect(callArgs.State).To(Equal(helm.StateDeleted)) | ||
|
|
||
| validateValues(g, callArgs.Values, cfg) | ||
| }) | ||
| t.Run("Success", func(t *testing.T) { | ||
| g := NewWithT(t) | ||
|
|
||
| helmM := &helmmock.Mock{} | ||
| snapM := &snapmock.Snap{ | ||
| Mock: snapmock.Mock{ | ||
| HelmClient: helmM, | ||
| }, | ||
| } | ||
| cfg := types.LocalStorage{ | ||
| Enabled: ptr.To(false), | ||
| Default: ptr.To(true), | ||
| ReclaimPolicy: ptr.To("reclaim-policy"), | ||
| LocalPath: ptr.To("local-path"), | ||
| } | ||
|
|
||
| status, err := localpv.ApplyLocalStorage(context.Background(), snapM, cfg, nil) | ||
|
|
||
| g.Expect(err).ToNot(HaveOccurred()) | ||
| g.Expect(status.Enabled).To(BeFalse()) | ||
| g.Expect(status.Version).To(Equal(localpv.ImageTag)) | ||
| g.Expect(helmM.ApplyCalledWith).To(HaveLen(1)) | ||
|
|
||
| callArgs := helmM.ApplyCalledWith[0] | ||
| g.Expect(callArgs.Chart).To(Equal(localpv.Chart)) | ||
| g.Expect(callArgs.State).To(Equal(helm.StateDeleted)) | ||
|
|
||
| validateValues(g, callArgs.Values, cfg) | ||
| }) | ||
| } | ||
|
|
||
| func TestEnabled(t *testing.T) { | ||
| t.Run("HelmApplyFails", func(t *testing.T) { | ||
| g := NewWithT(t) | ||
|
|
||
| applyErr := errors.New("failed to apply") | ||
| helmM := &helmmock.Mock{ | ||
| ApplyErr: applyErr, | ||
| } | ||
| snapM := &snapmock.Snap{ | ||
| Mock: snapmock.Mock{ | ||
| HelmClient: helmM, | ||
| }, | ||
| } | ||
| cfg := types.LocalStorage{ | ||
| Enabled: ptr.To(true), | ||
| Default: ptr.To(true), | ||
| ReclaimPolicy: ptr.To("reclaim-policy"), | ||
| LocalPath: ptr.To("local-path"), | ||
| } | ||
|
|
||
| status, err := localpv.ApplyLocalStorage(context.Background(), snapM, cfg, nil) | ||
|
|
||
| g.Expect(err).To(MatchError(applyErr)) | ||
| g.Expect(status.Enabled).To(BeFalse()) | ||
| g.Expect(status.Message).To(ContainSubstring(applyErr.Error())) | ||
| g.Expect(status.Version).To(Equal(localpv.ImageTag)) | ||
| g.Expect(helmM.ApplyCalledWith).To(HaveLen(1)) | ||
|
|
||
| callArgs := helmM.ApplyCalledWith[0] | ||
| g.Expect(callArgs.Chart).To(Equal(localpv.Chart)) | ||
| g.Expect(callArgs.State).To(Equal(helm.StatePresent)) | ||
|
|
||
| validateValues(g, callArgs.Values, cfg) | ||
| }) | ||
| t.Run("Success", func(t *testing.T) { | ||
| g := NewWithT(t) | ||
|
|
||
| helmM := &helmmock.Mock{} | ||
| snapM := &snapmock.Snap{ | ||
| Mock: snapmock.Mock{ | ||
| HelmClient: helmM, | ||
| }, | ||
| } | ||
| cfg := types.LocalStorage{ | ||
| Enabled: ptr.To(true), | ||
| Default: ptr.To(true), | ||
| ReclaimPolicy: ptr.To("reclaim-policy"), | ||
| LocalPath: ptr.To("local-path"), | ||
| } | ||
|
|
||
| status, err := localpv.ApplyLocalStorage(context.Background(), snapM, cfg, nil) | ||
|
|
||
| g.Expect(err).ToNot(HaveOccurred()) | ||
| g.Expect(status.Enabled).To(BeTrue()) | ||
| g.Expect(status.Version).To(Equal(localpv.ImageTag)) | ||
| g.Expect(helmM.ApplyCalledWith).To(HaveLen(1)) | ||
|
|
||
| callArgs := helmM.ApplyCalledWith[0] | ||
| g.Expect(callArgs.Chart).To(Equal(localpv.Chart)) | ||
| g.Expect(callArgs.State).To(Equal(helm.StatePresent)) | ||
|
|
||
| validateValues(g, callArgs.Values, cfg) | ||
| }) | ||
| } | ||
|
|
||
| func validateValues(g Gomega, values map[string]any, cfg types.LocalStorage) { | ||
| sc := values["storageClass"].(map[string]any) | ||
| g.Expect(sc["isDefault"]).To(Equal(cfg.GetDefault())) | ||
| g.Expect(sc["reclaimPolicy"]).To(Equal(cfg.GetReclaimPolicy())) | ||
|
|
||
| storage := values["node"].(map[string]any)["storage"].(map[string]any) | ||
| g.Expect(storage["path"]).To(Equal(cfg.GetLocalPath())) | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters